Re: [orbit-dev] Trying out the EBR approach for adding XML RPC 3.1.3 to

[erwindl0 <erwindl0@xxxxxxxxx>]

Thanks Roland, Gunnar.

I've tried using that property, setting it to ignore, but that didn't 
stop the NPE. Probably I made some mistake somewhere.
In the meantime it's no longer important as I've done the commit.

The CQ has been approved very quickly indeed (yippee), and I've done a 
gerrit push.
(https://git.eclipse.org/r/78687)

What is the process now?
1. Some more experienced Orbit-ers do a review and the merge? Or do I 
need to do some gerrit actions myself?
2. How/when would this end-up in a build that results in a stable p2 
repo location that I could then use in my Triquetrum target?

(apologies for all those questions, but this is my first "in orbit" 
contribution/experience)

regards
erwin


Op 8/9/2016 om 10:11 PM schreef Roland Grunberg:
> > > 3. tried the test builds per recipe
> > > I had to disable the Tycho JGit build-qualifier stuff due to NPEs
> > > otherwise.
> > > Cfr https://bugs.eclipse.org/bugs/show_bug.cgi?id=455007
> > > The test builds then work fine.
> > There should a property you can override on the command line to set it from
> > error to warning/ignore.
> I haven't run into such NPE, although the property Gunnar mentions
> (-DdirtyWorkingTree=warning) should prevent a build failure when you only have
> uncommitted content. According to the bug, if you set the property to ignore,
> and proceed with the build then it may fail if your modules are uncommitted.
>
> I would try committing your changes locally so that the jgit provider is able
> to generate timestamps.
>
> Also, ATO CQs generally don't take long to be approved as you can see :)
>
> Cheers,