| Re: [orbit-dev] Added commons.net 3.2.0 to Orbit |
|
Just FYI, since the issue has been fixed in upstream SVN (but not released), one option would be patching the one affected class file in Orbit and calling it Commons Net 3.2.0.1 to indicate the patch.
It’s just some 15 lines of code, so I’m confident that the Eclipse IP team could review it quickly if we wanted that: But I’m not sure if delivering something patched via Orbit, which upstream has not not yet released, is something we should do ? Any thoughts ? Thanks, Martin -- Martin Oberhuber, SMTS / Product Architect – Development Tools,
Wind River direct +43.662.457915.85 fax +43.662.457915.6 From: orbit-dev-bounces@xxxxxxxxxxx [mailto:orbit-dev-bounces@xxxxxxxxxxx]
On Behalf Of Oberhuber, Martin Hi Orbiteers, When testing the new commons net 3.2 , I found a regression in the library’s FTP support: https://bugs.eclipse.org/bugs/show_bug.cgi?id=408092 We can work around this regression in our code, since we’re calling the affected method only in one place (FTPClient#printWorkingDirectory()). In fact adding this workaround would be
my preference for the TM/RSE Project, since we haven’t updated Commons Net since the 2.2 release (Nov 22, 2010) and there are other
bug fixes related to IPv6 that we should adopt. But I’m wondering whether we even want a library with a severe known regression in Orbit … and if we do, what’s the best way warning other potential adopters, such that they don’t run
into the same problem when they pull Commons Net 3.2 from Orbit ? Thanks, Martin -- Martin Oberhuber, SMTS / Product Architect
– Development Tools, Wind River direct +43.662.457915.85 fax +43.662.457915.6 From:
orbit-dev-bounces@xxxxxxxxxxx [mailto:orbit-dev-bounces@xxxxxxxxxxx]
On Behalf Of Oberhuber, Martin Hi Orbiteers, I know it’s late with RC2 coming up, but I’ve just had to add Apache Commons Net 3.2.0 to Orbit as per this CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7043 I think I’ve done things right – after all it’s a simple version update from the previous Commons Net 3.1.0 . The build had been failing before my additions – let me know if anything seems to be missing (do we need a bugzilla for adding to Orbit ?) Thanks, Martin -- Martin Oberhuber, SMTS / Product Architect
– Development Tools, Wind River direct +43.662.457915.85 fax +43.662.457915.6 |