Re: [orbit-dev] Updating to Guice 3.0.0.no_aop

[Marcel Bruch <bruch@xxxxxxxxxxxxxxxxxx>]

hi Sebastian,

In source, yes. In the binary jar, these files are compiled to $StackFrames.class etc.
Can you check the contents of http://google-guice.googlecode.com/files/guice-3.0-no_aop.jar?


On 06.03.2012, at 13:58, Sebastian Zarnekow wrote:

> Hi Marcel,
> 
> what I see from the sources are the following types:
> Classes, LineNumbers, SourceProvider, StacktraceElements, Stopwatch
> 
> (see http://code.google.com/p/google-guice/source/browse/#git%2Fcore%2Fsrc%2Fcom%2Fgoogle%2Finject%2Finternal%2Futil)
> 
> Those aren't part of the final jar?
> 
> Regards,
> Sebastian
> 
> On 06.03.2012, at 13:52, Marcel Bruch wrote:
> 
>> I wonder if this will be useful in the case of Guice:
>> 
>> All classes in this package are prefixed with $<Classname>, e.g., $Lists.class Thus, I think, no-one can reuse them in their own code?
>> 
>> 
>> 
>> 
>> On 06.03.2012, at 13:46, Sebastian Zarnekow wrote:
>> 
>>> Hi Marcel,
>>> 
>>> please export c.g.i.internal.util as x-internal, too since all packages of a bundle should be exported (at least that's what I understand from http://wiki.eclipse.org/Adding_Bundles_to_Orbit#Export-Package_guidelines).
>>> 
>>> Regards,
>>> Sebastian
>>> 
>>> 
>>> On 06.03.2012, at 13:43, Marcel Bruch wrote:
>>> 
>>>> Hi,
>>>> 
>>>> I'm going to update Guice to 3.0.0 tonight (after the build is fixed). I've made a few changes to the original manifest which I'd like to present before committing this to Orbit:
>>>> 
>>>> 1. I've added com.google.inject.internal;version="1.3";x-internal:=true, since this package is used by XText.
>>>> 
>>>> 2. I renamed the Bundle-Version to 3.0.0.no_aop_qualifier to show that this bundle is the no-aop variant of Guice. The name "3.0.0.no_aop" is used by the Guice team itself. Here, however, I wonder whether a vendor attribute should be used if someone wants to use the standard Guice with AOP. If no-one stands up, I'll stick to the Guice-given defaults.
>>>> 
>>>> 3. I've added Eclipse-ExtensibleAPI: true to enable PDE to recognize and handle extension fragments properly. This was added 23.12.2011 to Guice.jar.
>>>> See http://code.google.com/p/google-guice/source/detail?r=abfe40d6bf6e3b1a3703869c85dae9a0315cb782
>>>> 
>>>> 
>>>> The final manifest is given below. If there are any issues with it (especially with Xtext needs), let me know.
>>>> 
>>>> Best,
>>>> Marcel
>>>> 
>>>> 
>>>> Manifest-Version: 1.0
>>>> Export-Package: com.google.inject;version="1.3",
>>>> com.google.inject.binder;version="1.3",
>>>> com.google.inject.internal;version="1.3";x-internal:=true,
>>>> com.google.inject.matcher;version="1.3",
>>>> com.google.inject.name;version="1.3",
>>>> com.google.inject.spi;version="1.3",
>>>> com.google.inject.util;version="1.3"
>>>> Bundle-Name: Google Guice (no_aop)
>>>> Bundle-RequiredExecutionEnvironment: J2SE-1.5,
>>>> JavaSE-1.6
>>>> Bundle-Copyright: Copyright (C) 2006 Google Inc.
>>>> Bundle-Vendor: Eclipse Orbit
>>>> Bundle-Version: 3.0.0.no_aop_qualifier
>>>> Bundle-ManifestVersion: 2
>>>> Bundle-Description: Guice is a lightweight dependency injection framew
>>>> ork for Java 5 and above
>>>> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt
>>>> Bundle-DocURL: http://code.google.com/p/google-guice/
>>>> Import-Package: javax.inject
>>>> Bundle-SymbolicName: com.google.inject
>>>> Eclipse-ExtensibleAPI: true
>>>> 
>>>> _______________________________________________
>>>> orbit-dev mailing list
>>>> orbit-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/orbit-dev
>>> 
>>> _______________________________________________
>>> orbit-dev mailing list
>>> orbit-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/orbit-dev
>> 
>> Thanks,
>> Marcel
>> 
>> -- 
>> Eclipse Code Recommenders:
>> w www.eclipse.org/recommenders
>> tw www.twitter.com/marcelbruch
>> g+ www.gplus.to/marcelbruch
>> 
>> _______________________________________________
>> orbit-dev mailing list
>> orbit-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/orbit-dev
> 
> _______________________________________________
> orbit-dev mailing list
> orbit-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/orbit-dev

Thanks,
Marcel

-- 
Eclipse Code Recommenders:
 w www.eclipse.org/recommenders
 tw www.twitter.com/marcelbruch
 g+ www.gplus.to/marcelbruch