Re: [orbit-dev] Fw: [ORBIT-BUILD: orbit-I] orbit-I build.545 Build Succ

[Hugues Malphettes <hmalphettes@xxxxxxxxxxx>]

Hi David,

Documentation:
------------------------
Yes one need to depend on the 4 bundles to get the full jsp-2.1 + jstl-1.2 support.

Here are the details:

jsp-api:
javax.servlet.jsp-2.1 requires javax.el-2.1

jsp-impl:
javax.el will searches by default for com.sun.el.ExpressionFactoryImpl as its implementation.
An alternative implementation would need to be a fragment of javax.el and contain META-INF/services/javax.el.ExpressionFactory to define another implementation.

javax.servlet.jsp-2.1 points by default to org.apache.jasper.runtime.JspFactoryImpl
To set an alternative default implementation, it is necessary to use the static method: javax.servlet.jsp.setDefaultFactory
In fact in jetty we are explicitly calling that method. It worked around some issue when using sun's jsf reference implementation.

jstl:
javax.servlet.jsp.jstl is a dependency of org.apache.taglibs only.
It does not seem to search for org.apache.taglibs by default either.
I am not sure how the wiring is done.

Here is the bundle that uses these jsp libraries in jetty: 
http://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/jetty/trunk/jetty-osgi/jetty-osgi-boot-jsp/

Should we stick to the short story: "please depend on the 4 bundles"?
Or should we start a wiki page with the fine details that I have not tested in depth myself?


Cleanup:
-------------
Thanks for pointing me to the build.properties. I removed 4 source folders amongst the jsp bundles.
I also added the plugin.properties that I had forgotten to include.
tagging and updating the map file.

Cheers,
Hugues

2010/3/31 David M Williams <david_williams@xxxxxxxxxx>

Thanks for the notes on the jsp bundles. I assume this means if someone wanted all functionality of javax.servlet.jsp , that they'd need to include all 4 of the related bundles?

Its very helpful to have that kind of thing well documented, so thank you.

Second topic, I just happened to notice in this build log, several messages that say
 [javac] Compile failed; see the compiler error output for details.

If I recall right, this is usually the result of having a "source folder" set (in build.properties, if not IDE) and yet there is no source found? Or something like that. (And, it'd be correct not to find it, we don't compile anything in Orbit).

I doubt it actually hurts anything ... but, thought I'd point out that there are some things that slip through our error and project layout checking ... so you could clean up as you are able. (Well, I'm assuming its the JSP related items, since that's were a lot of activity has been lately ... but,  I guess the messages could have been there a long time).

Thanks again,


----- Forwarded by David M Williams/Raleigh/IBM on 03/31/2010 06:05 PM -----

From:	David M Williams/Raleigh/IBM@IBMUS
To:	David M Williams/Raleigh/IBM@IBMUS, hmalphett@xxxxxxxxxxx
Date:	03/31/2010 05:35 PM
Subject:	[ORBIT-BUILD: orbit-I] orbit-I build.545 Build Successful

---

View results here -> http://build.eclipse.org:9777/dashboard/tab/build/detail/orbit-I?log=log20100331194330Lbuild.545

BUILD COMPLETE -  build.545
Date of build:	2010-03-31T19:43:30
Time to build:	110 minutes 45 seconds
Last changed:	2010-03-31T17:35:22
Last log entry:	Added some notes for the jsp bundles.

 Errors/Warnings: (22)

checkout.builder.clean: true
retieved new version of build.cfg
Version tag for org.eclipse.orbit/org.eclipse.orbit.releng.builder is: v201001140145
retieved new version of org.eclipse.orbit/org.eclipse.orbit.releng.builder
cctimestamp: 20100331194330
datetime: 201003311950
timestamp: 20100331194330
buildfile: /shared/orbit/projectBuilders/orbit-I/org.eclipse.orbit/org.eclipse.orbit.releng.builder/distribution/orbit.build/build.xml
   [javac] Compile failed; see the compiler error output for details.
   [javac] Compile failed; see the compiler error output for details.
   [javac] Compile failed; see the compiler error output for details.
   [javac] Compile failed; see the compiler error output for details.
buildDirectory: /shared/orbit/projects/orbit-I/workdir
chmod for /shared/orbit/projects/orbit-I/workdir/I20100331194330
rsyncRootPrefix:
buildDirectory: /shared/orbit/projects/orbit-I/workdir
buildLabel: I20100331194330
uploadUser: david_williams
uploadServer: download.eclipse.org
uploadRemoteDirectory: /home/data/users/david_williams/downloads/tools/orbit/committers/drops
RSYNC to: /home/data/users/david_williams/downloads/tools/orbit/committers/drops/I20100331194330
labelfile: /shared/orbit/projects/orbit-I/workdir/label.properties

 Unit Tests: (0)

No Tests Run

This project doesn't have any tests

Modifications since last successful build:  (6)
modified	hmalphett	/org.eclipse.orbit/org.eclipse.orbit.releng/ip_logs/javax.el.xml	1.3	2010-03-31T17:35:22	Added some notes for the jsp bundles.
modified	hmalphett	/org.eclipse.orbit/org.eclipse.orbit.releng/ip_logs/com.sun.el.xml	1.3	2010-03-31T17:35:20	Added some notes for the jsp bundles.
modified	hmalphett	/org.eclipse.orbit/org.eclipse.orbit.releng/ip_logs/javax.servlet.jsp.jstl.xml	1.3	2010-03-31T17:35:20	Added some notes for the jsp bundles.
modified	hmalphett	/org.eclipse.orbit/org.eclipse.orbit.releng/ip_logs/javax.servlet.jsp.xml	1.5	2010-03-31T17:35:20	Added some notes for the jsp bundles.
modified	hmalphett	/org.eclipse.orbit/org.eclipse.orbit.releng/ip_logs/org.apache.jasper.glassfish.xml	1.3	2010-03-31T17:35:20	Added some notes for the jsp bundles.
modified	hmalphett	/org.eclipse.orbit/org.eclipse.orbit.releng/ip_logs/org.apache.taglibs.standard.glassfish.xml	1.3	2010-03-31T17:35:20	Added some notes for the jsp bundles.

_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev