Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orbit-dev] Exporting packages with version

I assume that most bundles (if not all) in Orbit have versions on their exports. I don't think we can do this automatically via script because people may version their packages a bit different (e.g., version them individually versus using the Bundle-Version)

In PDE, we have a compiler preference to flag this as an error if you want:

Plug-in Development -> Compilers -> Versioning -> Missing versions on export packages

We could make sure that this is in a project preference for all Orbit bundles.

On Mon, Feb 16, 2009 at 8:17 AM, Oberhuber, Martin <Martin.Oberhuber@xxxxxxxxxxxxx> wrote:
Hi all,
 
I'm wondering whether we should be starting a collective effort to add version numbers
to package exports now that Galileo M5 is done.
 
I guess that in most cases, it should be a simple rewrite of the MANIFEST.MF,
adding the bundle version number to all the package exports.
 
Is this worth writing a little script for the good of all, or are we going to do
it manually?
 
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
 
 


From: orbit-dev-bounces@xxxxxxxxxxx [mailto:orbit-dev-bounces@xxxxxxxxxxx] On Behalf Of Jeff McAffer
Sent: Freitag, 30. Jänner 2009 22:47
To: Orbit Developer discussion
Subject: Re: [orbit-dev] Two bundling questions

While i'm in echo mode, I agree with Chris here.  We should not be recompiling anything.  Actually, we are not really supposed to have the source in the Orbit repo in "check-out-able project form" (a zip/jar of the source is ok but the way our CQs are done implies that people should not be able to simply check out hte source and use/edit it directly in their workspace).

if you need line numbers and the upstream folks do not want to supply it then, it sucks but, perhaps you have to recompile it yourself or check their code out into the workspace.

As for exporting package version numbers, yes, everyone should be putting version numbers on their exports.
Jeff

Chris Aniszczyk wrote:
On Fri, Jan 30, 2009 at 6:27 AM, Oberhuber, Martin <Martin.Oberhuber@xxxxxxxxxxxxx> wrote:
Hi Orbiter's,
 
I have two bundling questions:
  • I have a case of a lib that comes precompiled without debug info. For Eclipse, I'd like to bundle the source and have it built with debug info, because I have occasionally run into cases where I wanted to debug into it. Does it make sense to rebuild with debug info? For the CQ, would it still qualify as "unmodified source and binary" since it's built from exactly the same sources? FYI, I'm talking about JSch on  http://dev.eclipse.org/ipzilla/show_bug.cgi?id=3040
I would prefer not to recompile things unless it's really needed. Can we talk with upstream to get them to compile with debug symbols?
 

  • In our MANIFEST.MF, do we want to start exporting all packages with version number (such that import-package with version number would work for those that prefer it over require-bundle)? Should we put a related "best practice" item on the Wiki?
Yes please. All packages should be exported with a version number. We should also strive to use Import-Package over Require-Bundle in Orbit so we can play nice with others. For example, I've seen issues with some of the Orbit libraries and the ones in BRITS (SpringSource).

Cheers,

~ Chris

_______________________________________________ orbit-dev mailing list orbit-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/orbit-dev

_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev




--
Chris Aniszczyk | EclipseSource Austin | +1 860 839 2465
http://twitter.com/caniszczyk | http://twitter.com/eclipsesource

Back to the top