While i'm in echo mode, I agree with Chris here. We should not be
recompiling anything. Actually, we are not really supposed to have the
source in the Orbit repo in "check-out-able project form" (a zip/jar of
the source is ok but the way our CQs are done implies that people
should not be able to simply check out hte source and use/edit it
directly in their workspace).
if you need line numbers and the upstream folks do not want to supply
it then, it sucks but, perhaps you have to recompile it yourself or
check their code out into the workspace.
As for exporting package version numbers, yes, everyone should be
putting version numbers on their exports.
Jeff
Chris Aniszczyk wrote:
On Fri, Jan 30, 2009 at 6:27 AM, Oberhuber, Martin <Martin.Oberhuber@xxxxxxxxxxxxx>
wrote:
Hi Orbiter's,
I have two bundling
questions:
- I have a case of a lib that
comes precompiled without debug info. For Eclipse, I'd like to bundle
the source and have it built with debug info, because I have
occasionally run into cases where I wanted to debug into it. Does it
make sense to rebuild with debug info? For the CQ, would it still
qualify as "unmodified source and binary" since it's built from exactly
the same sources? FYI, I'm talking about JSch on http://dev.eclipse.org/ipzilla/show_bug.cgi?id=3040
I would prefer not to recompile things unless it's really
needed. Can we talk with upstream to get them to compile with debug
symbols?
- In our MANIFEST.MF, do we
want to start exporting all packages with version number (such that
import-package with version number would work for those that prefer it
over require-bundle)? Should we put a related "best practice" item on
the Wiki?
Yes please. All packages should be exported with a version number. We
should also strive to use Import-Package over Require-Bundle in Orbit
so we can play nice with others. For example, I've seen issues with
some of the Orbit libraries and the ones in BRITS (SpringSource).
Cheers,
~ Chris
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev
|
