Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[orbit-dev] More fixes needed for IP related documentation

Orbiteers, please see this bug (and below) for some initial review of our about.html files, etc.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=234485

Offhand, it seems to me there is a lot of work to do by June 2nd! (well, ideally by then, so our final S build is real close to what will be our R build for Ganymede.

There is too much for me to open a bug for each person who needs to make fixes .. so, please open your own, for any bundles you are responsible for.
This includes those listed in these review notes, but suspect we can proactively make many fixes based on the patterns seen in this list.
After you open your bug, please list is as a blocks (depends-on) for bug 234485 so we can easily see progress being made.

Thanks,

- - - - -
Remaining schedule:

 June 2 - promote latest S-build to 'downloads'
 
 After June 2nd, we'd start to produce R builds on 'committers' site,
 and promote it as the final Ganymede orbit build on ...
 
 June 9 - promote latest R-build to 'downloads' (and a day or two
 later, remove all the S-builds).
- - - - -


Below is an rtf version of what is in the bug. I've included it here, since easier to read, if the rtf survives your mail reader.

* * * *
I am working through the Orbit About files as they appear in alphabetical order.  I estimate I am approximately 50% complete:  this preliminary feedback is on files up to and including org.apache.batik; will continue in alphabetical order from org.apache.bcel.   I thought I’d give you some preliminary feedback so you can work on these items while I review the remainder of the files.   

 

Please feel free to call if I haven’t been clear in some spots.  Thanks!

 

*********************************************************************************
1.        ch.ethz.iks.slp.source_1.0.0.RC2_v200803061811.jar
a.        Why is there reference to Apache Commons Collections in the jSLP section?
b.        There is no pointer referencing the location of the origins of the source code.
2.        ch.ethz.iks.slp_1.0.0.RC2_v20080505-0900.jar
a.        Why is there reference to Apache Commons Collections in the jSLP section?
b.        There is no pointer referencing the location of the origins of the source code.
3.        com.ibm.icu.base.source_3.4.5.jar and com.ibm.icu.base.source_3.6.0.v20080304.jar and com.ibm.icu.base.source_3.6.1.v20080304.jar and com.ibm.icu.source_3.4.5.jar and com.ibm.icu.source_3.6.1.v20080304.jar
a.        No information – points to other subdirectories for various source code applications:
Source Code

This plug-in contains source code zip files ("Source Zips") that correspond to binary content in other plug-ins. These Source Zips may be distributed under different license agreements and/or notices. Details about these license agreements and notices are contained in "about.html" files ("Abouts") located in sub-directories in the src/ directory of this plug-in. Such Abouts govern your use of the Source Zips in that directory, not the EPL.
4.        com.ibm.icu.base.source_3.8.1.v20080402.jar and com.ibm.icu.base_3.4.5.jar and com.ibm.icu.base_3.6.0.v20080304.jar and com.ibm.icu.base_3.6.1.v20080304.jar and com.ibm.icu.base_3.8.1.v20080402.jar and com.ibm.icu.source_3.6.0.v20080304.jar and com.ibm.icu.source_3.8.1.v20080402.jar and com.ibm.icu_3.4.5.jar and ibm.icu_3.6.0.v20080304.jar and com.ibm.icu_3.6.1.v20080304.jar and com.ibm.icu_3.8.1.v20080402.jar
a.        There is no pointer or link referencing the location of the origins of the source code.
b.        There is a license for Unicode Data, but there is no mention of Unicode Data in the about file. 
c.        Limited solely to version 3.8.1, the about files reference version 3.8.
5.        Jcraft.jsch 0.1.28 does not contain the same Cryptography warning as the other versions.  Is that because it does not contain the same encryption methods? 
6.        Java.cup runtime needs a version number and pointer to URL where source is available.
7.        javax.jws_2.0.0.v200803061811.jar
a.        needs a pointer to URL where source is available
b.        about says it’s governed by CDDL, but links to the license and the license.txt itself are both ASL 2.0
8.        javax.servlet.jsp.source_2.0.0.v200803061910.jar about file information doesn’t match the filename and version number described in About file:  jsp-api.jar from Tomcat 5.5.17
9.        javax.servlet.jsp_1.2.0.v200803061811.jar about file information doesn’t match the filename and version number described in About file::  servlet.jar from Tomcat 4.1.30
10.        javax.servlet.jsp_2.0.0.v200803061910.jar about file information doesn’t match the filename and version number described in About file:  jsp-api.jar from Tomcat 5.5.17.  In addition, source code URL is missing.
11.        javax.servlet.source_2.3.0.v200803061811.jar about file information doesn’t match the filename and version number.  About file describes the following pkg:  servlet.jar from Tomcat 4.1.30
12.        javax.servlet.source_2.4.0.v200803061910.jar about file information doesn’t match the filename and version number described in About file:  jsp-api.jar from Tomcat 5.5.17.  In addition, source code URL is missing.
13.        javax.servlet.source_2.5.0.v200804152124.jar about file information is incomplete.  Generic reference to contains third party source code, much the same as the ICU jars above.
14.        javax.servlet_2.3.0.v200803061811.jar about file information doesn’t match the filename and version number.  About file describes the following pkg:  servlet.jar from Tomcat 4.1.30
15.        javax.servlet_2.4.0.v200803061910.jar about file information doesn’t match the filename and version number described in About file:  jsp-api.jar from Tomcat 5.5.17.  In addition, source code URL is missing.
16.        javax.servlet_2.5.0.v200804152124.jar about file information doesn’t match the filename and version number described in About file:  jsp-api.jar from Tomcat 6.0.14.  In addition, source code URL is missing.
17.        javax.wsdl15_1.5.1.v200705290614.jar about file says the governing license is the IBM Public License, but the CPL is the one attached. 
18.        javax.wsdl_1.4.0.v200803061811.jar about file says the governing license is the IBM Public License, but the CPL is the one attached. 
19.        javax.wsdl_1.5.1.v200803061910.jar about file says the governing license is the IBM Public License, but the CPL is the one attached. 
20.        javax.wsdl_1.6.2.v200805051533.jar about file says the governing license is the IBM Public License, but the CPL is the one attached. 
21.        javax.xml.bind.source_2.0.0.v200803061811.jar is missing source code URL.
22.        javax.xml.bind_2.0.0.v200803061811.jar is missing source code URL.
23.        javax.xml.rpc_1.1.0.v200803061811 is missing the version number of the RPC, and the source code URL.
24.        javax.xml.soap_1.2.0.v200803070511 is missing the version number of SOAP, and the source code URL.
25.        javax.xml.ws_2.0.0.v200803070400.jar is missing the source code URL.
26.        javax.xml_1.3.4.v2008041723.jar does not match the naming and versioning in the about file:  Xerces2 Java Parser 2.9.0
27.        org.apache.batik.bridge_1.6.0.v200803061811.jar and all folders in alpha order up to and including org.apache.batik.parser_1.6.0.v200803061811.jar have a NOTICE states that the package includes: 

 

This software contains code from the World Wide Web Consortium (W3C) for the

Document Object Model API (DOM API) and SVG Document Type Definition (DTD).

 

This software contains code from the International Organisation for Standardization

for the definition of character entities used in the software's documentation.

 

      But the about file does not reference either of those third parties.

 
28.        a) org.apache.batik.pdf_1.6.0.v200803061811.jar has a NOTICE states that the package includes: 

 

This software contains code from the World Wide Web Consortium (W3C) for the

Document Object Model API (DOM API) and SVG Document Type Definition (DTD).

 

This software contains code from the International Organisation for Standardization

for the definition of character entities used in the software's documentation.

 

      But the about file does not reference either of those third parties.

 

b)  Same jar file has 4 licenses:  1 Apache 2.0 and 3 Apache 1.1 for 3 different packages:  Avalon, commons io and commons logging.  There is no reference to any of the last 3 packages in the about file.

 
29.        org.apache.batik.svggen.source_1.6.0.v200803061811.jar, org.apache.batik.svggen_1.6.0.v200803061811.jar, org.apache.batik.swing.source_1.6.0.v200803061811.jar, org.apache.batik.swing_1.6.0.v200803061811.jar, org.apache.batik.util.gui.source_1.6.0.v200803061811.jar, org.apache.batik.util.gui_1.6.0.v200803061811.jar, org.apache.batik.util.source_1.6.0.v200803061811.jar, org.apache.batik.util_1.6.0.v200803061811.jar, org.apache.batik.xml.source_1.6.0.v200803061811.jar and org.apache.batik.xml_1.6.0.v200803061811.jar have NOTICE files that state that the package includes: 

 

This software contains code from the World Wide Web Consortium (W3C) for the

Document Object Model API (DOM API) and SVG Document Type Definition (DTD).

 

This software contains code from the International Organisation for Standardization

for the definition of character entities used in the software's documentation.

 

      But the about file does not reference either of those third parties.

 

30. org.apache.batik.transcoder.source_1.6.0.v200803061811.jar and org.apache.batik.transcoder_1.6.0.v200803061811.jar

a.  contain about files that state, among other things,

Batik is a subset of the original distribution available from the Apache Software Foundation and does NOT include:

·        Rhino

·        Xerces-J

·        PDF Transcoder

Yet, it would appear that this package is “Transcoder”….?  

 
b.        In addition both files have NOTICE files that state that the package includes: 

 

This software contains code from the World Wide Web Consortium (W3C) for the

Document Object Model API (DOM API) and SVG Document Type Definition (DTD).

 

This software contains code from the International Organisation for Standardization

for the definition of character entities used in the software's documentation.

 

      But the about file does not reference either of those third parties.

 

*********************************************************

Back to the top