Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [nebula-dev] Incubation build is broken

Hi Dirk,

Thanks for the update and the pointers. I have moved the build to Tycho2 Java11.

I had to disable paginationtest due to javax.annotation missing when starting photon. Probably photon cannot run on Java 11.

Cheers,

Wim


On Wed, Sep 16, 2020 at 2:57 PM Dirk Fauth <dirk.fauth@xxxxxxxxx> wrote:
Well we need to:

- update the Tycho version in the parent pom (as we are not using pomless Tycho, there is no extension to update)
- update all Jenkins builds to run with Java 11 (required by Tycho 2.0)
- I already set the properties that source and target should be 1.8 and removed the BREE configuration from the profile, so that should be fine
- we probably need to add javax.annotation to the imported packages of some projects (e.g. examples) as we are using the E4 javax.annotations there. Not sure which projects are affected, but we will see then.  

Then we need to check some of the projects. In incubation the pagination.tests always failed because javax.annotation can't be resolved. I already did several modifications as you can see, but none of them worked. My last guess is that the Require-Bundle configuration is causing the troubles, because all the required stuff (SWT, JFace, etc.) is configured as optional, because it should also work with RAP IIUC. I think changing this to Import-Package (AFAIK RAP exports the same packages as SWT, but my experience with RAP is not that good) it should work. All other test projects work fine with this configuration. I locally excluded pagination.tests from the modules and the incubation build with Java 11 succeeded locally.

In stable there are also some test projects that fail, e.g. CDateTime. Not sure why. Looks like some GTK issue. It is currently solved via -DskipTests=true. But that can also not be the solution. We could try to exclude only that test project from the modules to ensure that the others are working.

Hope that's it. Let me know if I can help you with something. 

On Wed, Sep 16, 2020 at 2:37 PM Wim Jongman <wim.jongman@xxxxxxxxx> wrote:
Thanks, Dirk. Yes, we do need to go to Tycho 2. What must we do?

Cheers,

Wim

On Wed, Sep 16, 2020 at 2:27 PM Dirk Fauth <dirk.fauth@xxxxxxxxx> wrote:
Seems I was faster ;)

But there are still some issues we need to take care of in the near future if we want to update to Tycho 2.0 which requires Java 11 to build. 

Wim Jongman <wim.jongman@xxxxxxxxx> schrieb am Mi., 16. Sept. 2020, 13:10:
Hi,

I am aware that the incubation build is broken. I am trying to fix it.

Cheers,

Wim
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/nebula-dev
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/nebula-dev
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/nebula-dev
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/nebula-dev

Back to the top