| Re: [nebula-dev] Dealing with line endings |
Unfortunately EGit/JGit does not use .gitattributes, which can lead to problems if you used a mixed “command line git”/EGit workflow - do a bugzilla search for gitattributes.
I suspect that use of .gitattributes for Nebula is not suitable.
Matthew
From: nebula-dev-bounces@xxxxxxxxxxx [mailto:nebula-dev-bounces@xxxxxxxxxxx] On Behalf Of Dirk Fauth
Sent: 11 December 2013 13:22
To: Nebula Dev
Subject: Re: [nebula-dev] Dealing with line endings
Here are some additional resources:
http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/
http://schacon.github.io/git/gitattributes.html (important is the section on normalization, as the one in the first link didn't work 100% in NatTable)I also attach a sample .gitattributes to this mail. This is the one we are using in NatTable.
Although I'm a Nebula committer, I don't want to perform actions that potentially will touch a lot of source files in the whole Nebula project. Maybe Wim will test this first locally?
Greez,
Dirk
On Tue, Dec 10, 2013 at 5:11 PM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:
+1
On Tue, Dec 10, 2013 at 2:08 PM, Dirk Fauth <dirk.fauth@xxxxxxxxx> wrote:
Hi,
I just came across the line ending issues when working with Git where the OS of the committers is not unique.
In [1] is explained that you can handle this by local Git configuration (core.autocrlf) and/or via .gitattributes directly in the repository. Adding the .gitattributes should handle things correctly even if the local Git configuration property is missing. At least I understand it that way.
Wouldn't it make sense then to add such a .gitattributes to Nebula too? Rejecting contributions because of wrong line endings when it can be handled automatically feels wrong.
What do you think?
Greez,
Dirk
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev