| Re: [nebula-dev] Contributions to Nebula GanttChart |
Hi Wim,
I renamed your method because of the meaning of the method. My getCommands() is the getter for the commands while your getCommands() do some additional processing in flattening the commands. So in terms of API design it is the better choice. But of course I can change that. Any suggestions for another name to the real getter?
About the CQ, afaik the ip approval is necessary as I'm not a committer for nebula but for NatTable. But I might be wrong. :-)
Greez,
Dirk
Hi Dirk/Emil,Your reasoning sounds fine to me. About changing that API contract; you can't do that. Instead of renaming the getCommands method, why didn't you introduce a new API method that serves your need? Or is there no impact on users using the getCommands method?About the >500 lines and CQ. Since you are already a Nebula committer and have signed the CLA, I don't think this is required. I have pinged Wayne on the bug.@Emil, when do you plan to integrate Dirks changes?Best regards,Wim
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev