Re: [nebula-dev] Contributions to Nebula GanttChart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [nebula-dev] Contributions to Nebula GanttChart

From: Wim Jongman <wim.jongman@xxxxxxxxx>
Date: Sat, 27 Jul 2013 10:40:14 +0200
Delivered-to: nebula-dev@xxxxxxxxxxx
List-archive: <https://dev.eclipse.org/mailman/private/nebula-dev>
List-help: <mailto:nebula-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/nebula-dev>, <mailto:nebula-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/options/nebula-dev>, <mailto:nebula-dev-request@eclipse.org?subject=unsubscribe>

Hi Dirk/Emil,

Your reasoning sounds fine to me. About changing that API contract; you can't do that. Instead of renaming the getCommands method, why didn't you introduce a new API method that serves your need? Or is there no impact on users using the getCommands method?

About the >500 lines and CQ. Since you are already a Nebula committer and have signed the CLA, I don't think this is required. I have pinged Wayne on the bug.

@Emil, when do you plan to integrate Dirks changes?

Best regards,

Wim

Follow-Ups:
- Re: [nebula-dev] Contributions to Nebula GanttChart
  - From: Dirk Fauth

References:
- [nebula-dev] Contributions to Nebula GanttChart
  - From: Dirk Fauth
- Re: [nebula-dev] Contributions to Nebula GanttChart
  - From: Emil Crumhorn
- Re: [nebula-dev] Contributions to Nebula GanttChart
  - From: Dirk Fauth
- Re: [nebula-dev] Contributions to Nebula GanttChart
  - From: Dirk Fauth

Prev by Date: Re: [nebula-dev] Contributions to Nebula GanttChart
Next by Date: Re: [nebula-dev] Contributions to Nebula GanttChart
Previous by thread: Re: [nebula-dev] Contributions to Nebula GanttChart
Next by thread: Re: [nebula-dev] Contributions to Nebula GanttChart
Index(es):
- Date
- Thread

Breadcrumbs