Re: [nebula-dev] Contributions to Nebula GanttChart

[Dirk Fauth <dirk.fauth@xxxxxxxxx>]

Hi,

sorry, I didn't wanted to wait any longer. Of course I just wrote you the mail, but I wanted to get my additions contributed before the weekend.

@Wim

I changed your method to be named getFlattenedCommands(), which should be what it is intended to do, right?

The last contribution is attached to this bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=413822

As it is a bigger contribution compared to the others, I guess we need IP approval for that (>500 lines of code).

So for now everything I modified and extended in GanttChart the last year is contributed in form of patches attached to tickets. It should be 21 patches as far as I can see in my directory.

Hopefully they do not break anything. But AFAIK they are working pretty fine in my application and I tried to ensure that everything is backwards compatible.

Let me know what you think and if there is anything wrong.

The next extension will be to make the GanttChart printable. As this is something I wanted to start with next week, I wanted to be sure to contribute the other stuff first. So the printing stuff can be also contributed soon. If you have any hints on printing the GanttChart let me know. Any help is appreciated.

Greez,
Dirk

P.S. Sorry that I didn't wait for your responses, but it has 36 degrees in Germany, and in the office it feels a lot hotter. And I need to go home now! :) But as it is only a patch, I am also able to adjust it before you commit and so you are able to have a look in detail what the changes are.

On Fri, Jul 26, 2013 at 2:59 PM, Dirk Fauth <dirk.fauth@xxxxxxxxx> wrote:

Hi Emil, hi Wim,

I have contributed almost every change I have made locally. There is just one left. But that one is also quite huge. It's about undo/redo handling. Even for deleting events and sections. I have rewritten a lot of code regarding undo/redo. As I just noticed that Wim also did something on that a year ago, I wanted to talk to you before I contribute. Maybe I can adjust my changes so they don't hurt others too much.

Here are my questions:

In the ClusteredCommand Wim added the methods public List getCommands() and public List getEvents(). getCommands() unpacks the clustered commands to have a flat collection. And the returned list ist unmodifiable. Now this fact hurts my implementation, where I simply return the local referenced collection _commands.
The reason why I need the collection itself modifiable is that it needs to be possible to change the order of the events. This is because a) if you delete more events at once, the order of the events on restoring depends on the order how they where selected. Therefore the stair effect breaks on undo b) if you e.g. want to delete a section automatically if the last event was deleted in the section, you need to change the order of the commands dependent if you undo or redo, as on undo you need to first undo the section delete and then the event delete, on redo you need to switch. It is also necessary in this case to keep the clustering in the cluster if there is any. So the two implementations of getCommands() collide.

@Wim

What do you think is the best way to get our requirements together? Because I don't find internal usage of those methods, maybe we could rename your methods and use getCommands() as simple getter. What do you think?

I also changed the EventMoveCommand to store the reference to the GanttSection directly rather than storing the index. This is because I think the calculation of the section for every call is not necessary and also it might crash because the index might change if you take deletion of sections into account.

Where there any important reasons to only store the indeces rather than the reference to the GanttSection directly?

Greez,

Dirk

On Wed, Jun 26, 2013 at 11:05 AM, Emil Crumhorn <emil.crumhorn@xxxxxxxxx> wrote:

Hi Dirk,

That's great to hear! There's definitely a lot of things I have not had time to fix with the Gantt Chart and features that people have requested, so hopefully your changes will improve it a lot.

Look forward to the patches!

Cheers,

Emil

On Wed, Jun 26, 2013 at 10:37 AM, Dirk Fauth <dirk.fauth@xxxxxxxxx> wrote:

Hi everybody,

the last year I worked in a customer project that makes heavy use of the GanttChart. It does what it is intended to do, but has several issues and missing features that are necessary for our customer.

When we started the project I wasn't an Eclipse committer and therefore I started cloning and working independently. Since I am a committer, I realized that it was the totally wrong approach. That said, I want to contribute back my fixes and additions to the GanttChart . Also because our customer wants to have some further additions and I don't want to increase the gap between official available software and the customized one.

As there was the move from SVN to Git in the meantime, I started today cloning the repo and merging the changes by hand. Hopefully I'm able to document every change in detail. I will try to open a ticket for every change and attach the corresponding patch to it, so the changes can be committed step by step.

So if you wonder about incoming Gantt tickets the next days, it's me contributing. I will write again when I'm done, so someone can please have a look and commit if it is ok.

Greez,

Dirk

_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev

_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev