Re: [nebula-dev] CDateTime enhancements

[Scott Klein <Scott.Klein@xxxxxxxxxxxxxx>]

https://bugs.eclipse.org/bugs/show_bug.cgi?id=370605

Bug was created, hopefully I have provided enough detail in there. Also, see my comment on the patch I attached - I will address those issues but if you would like to provide guidance please do so.

I am currently looking at the test cases and will work on those - I will create a new test case for my bug number for submission.

Just to be sure, I am expecting that this will *not* get applied to the head until I have completed the test case -- but please use the patch to review and make recommendations on code style, format, commenting, horrible code, etc

thanks
scott

-----Original Message-----
From: nebula-dev-bounces@xxxxxxxxxxx [mailto:nebula-dev-bounces@xxxxxxxxxxx] On Behalf Of Wim Jongman
Sent: Friday, February 03, 2012 11:46 AM
To: Nebula Dev
Subject: Re: [nebula-dev] CDateTime enhancements

Hi Scott,

Thank you for the patch. Please file a bug against technology.nebula, attach the patch there and I will implement it.

Cdatetime has a great unit test suite. Are you happy to provide a test for your case as well?

Regards,

Wim



On 3 feb. 2012, at 00:32, Scott Klein <Scott.Klein@xxxxxxxxxxxxxx> wrote:

> All -
>
> First, thanks for all the work on these nebula controls. I love them and have been transitioning to them when possible in our application.
>
> I have two items of concern with the CDateTime control:
>
> 1. Using the arrow keys, hours do no transition properly around
> Daylight Savings Time epochs (fall back doesn't fall back thru the two
> 1 AMs) 2. Users are unable to alter the time zone within the control
>
> I have solved the first problem by introducing a fieldRoll() method to
> use in place of the fieldSet() method when arrow keys are being used
> (fieldSet() is still used when a user types in a value)
>
> I have solved the second problem by introducing a setPattern( String pattern, TimeZone[] allowedTimeZones ) method.
> * This sets a field (allowedTimeZones), which is then used to make the
> decision (null or not null) whether to allow the user to tab into the
> time zone field
> * The allowedTimeZones field is then used to roll thru timezones when
> arrow keys are used on the time zone field
>
> I have attached a patch for those that want to take a look -- it is pretty straightforward for the most part. More importantly, I am interested in hearing if this is something that might be included so I can decide whether to branch out my own control for my work.
>
>
>
> thanks
> scott
>
>
>
>
>
> __________ Information from ESET NOD32 Antivirus, version of virus
> signature database 6851 (20120202) __________
>
> The message was checked by ESET NOD32 Antivirus.
>
> http://www.eset.com
>
> <patch-CDateTime.1.33.txt>
> _______________________________________________
> nebula-dev mailing list
> nebula-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/nebula-dev
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev


__________ Information from ESET NOD32 Antivirus, version of virus signature database 6855 (20120203) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com



__________ Information from ESET NOD32 Antivirus, version of virus signature database 6855 (20120203) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com