Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [nebula-dev] More on the build
Hi Wim, all,

Le 21 nov. 2011 à 01:16, Wim Jongman a écrit :

 
We would have :
org.eclipse.swt.nebula.examples  - App + release widgets
org.eclipse.swt.nebula.examples.incubation - incubation widgets.

Exactly my idea! Are you my long lost twin? There is also one other solution to create .example bundles for each plugin. The examples bundle has a nice extension point and therefore it would not be dependent on anything. If the widget supplies a .example plugin then it gets added to the examples view automagically. 
:-)
Sure, I was planning to have only fragment in the incubation plugin. 
I'm still worried about the large number of plugins we have in Nebula. One example plugin per widget is still possible, maybe with another layout (see bellow)

Haleluja! I think we should not be in the swt namespace. The idea that some of the widgets would ever make it to core swt is not reasonable. Therefore I vote for o.e.nebula. 

+1 for removing .swt everywhere

Also, some features lay around in the bundle directory and the feature naming is also inconsistent. Some have _feature and some have .feature. We should fix that as well.
+1 for following the eclipse convention which seems to be .feature.

 
The only issue is that CVS prevent us to move files if we want to keep history and does not allow to remove folders This means that any cleanup will result in more mess in the CVS exploring view or in CVS Web access.

To ensure we can do all the refactoring, I think we should move to SVN or git ASAP. We already discussed of this topic on this list and the choice was git if I remember correctly.

Should be start converting the repo right now ?


yes go to git.

Before proceeding to the conversion, I would like to make sure that every committer has read the following wiki pages. Git is different from CVS/SVN and even the Eclipse process for contributions is different so be prepared for a lot of changes. 


Is this ok for everyone ?


Nicolas, thanks for jumping in with me. We should coordinate so that we do not cross our beams. 
I'm quite busy this week so you can start if you want to.

Let's freeze the current repo and do the transfer to git with restructuring.
+1

Suggestion for structure:

bundles
   o.e.n.widgets.widget1
   o.e.n.widgets.widget2
features
  o.e.n.widgets.widget1.feature
  o.e.n.widgets.widget2.feature
examples
  o.e.n.examples
  o.e.n.widgets.widget1.example  <-- using the examples extension point
  o.e.n.widgets.widget2.example
  o.e.n.widgets.widget1.snippets
  o.e.n.widgets.widget2.snippets
releng
  all top level releng features
  update site project
tests
  o.e.n.widgets.widget1.tests
attic
    releng
       all obsolete releng projects

What about this structure ? 

*  widget1
     o.e.n.widgets.widget1
     o.e.n.widgets.widget1.feature
     o.e.n.widgets.widget1.tests
     o.e.n.widgets.widget1.tests.feature
     o.e.n.widgets.widget1.example
     o.e.n.widgets.widget1.snippets

* widget2
    (...)

* example
    o.e.n.example (core)

* update site

 * attic

pom.xml


This would make it easier to check out and work on a single widget
And we could insert a pom.xml in each widget directory to build the whole widget (tests, features, ...) with a single command.


Regards, 

Nicolas

Lets get out of the swt namespace and rename all _feature to .feature

Regards,

Wim 


--
Nicolas


Le 19 nov. 2011 à 23:09, Wim Jongman a écrit :

> Hi Nicolas,
>
> Allright this makes sense. I missed the history.
>
> The oscilloscope tests are running now. I switched it to another junit version.
>
> Regards
>
> Wim
>
> Sent from my iPhone
>
> On 19 nov. 2011, at 22:21, Nicolas Richeton <nicolas.richeton@xxxxxxxxx> wrote:
>
>> Hi Wim, Tom,
>>
>> There are several reasons why we have only 2 builds :
>>
>> * When we were building using cron jobs and athena, we had 1 job per widget. As Tom said, it was introducing a lot of overhead when updating the build process or adding a new widget.
>> * With Hudson, we cannot manage jobs directly : creating a new job requires an action from the webmaster. (However, this does to take long)
>> * Eclipse webmasters do not like having 15 builds for a single project. This creates a lot of unnecessary load on serveurs.
>> * As discussed in this list, we are trying to do a stable release of Nebula. This implies releasing several widgets at once. Since we won't be doing separate release, a failing build should be an issue for all committers, not only for the one responsible of this widget.  (This is true mostly for  the stable build).
>>
>> In my opinion, it would be a great if at some point, each committer has enough knowledge to work on any Nebula widget. This would increase overall quality and speed up development and bug fixes.
>> I think that using only 2 builds will help us to reach that point, since we cannot ignore a broken widget and everyone will be somehow responsible to do the fix (thus work on every widget).
>>
>>> BTW can't one
>>> configure tycho to proceed even if the tests are failing?
>>
>> I think this is generally a bad idea as this would mean that failing tests are  a minor issue and they are not. :-)
>>
>> I'll try to look at failing and remaining tests next week (composite table, oscilloscope,  and xviewer).  Can I update tests which cause issues (based on gallery ones) ?
>>
>> I also requested the reactivation of my shell account so I can look at the download area (just received a mail because we are using 9Gb and quota is 2Gb max)
>>
>> --
>> Nicolas
>>
>> Le 19 nov. 2011 à 02:28, Tom Schindl a écrit :
>>
>>> Hi,
>>>
>>> Then they have to comment out their tests until they can be run
>>> successful - this how it is done also in other projects. BTW can't one
>>> configure tycho to proceed even if the tests are failing?
>>>
>>> Tom
>>>
>>> Am 19.11.11 02:22, schrieb Wim Jongman:
>>>> Hi,
>>>>
>>>> Let me explain a bit better:
>>>>
>>>> For example, the composite table tests do not run correctly [1].  It is
>>>> not that they fail but for some reason tycho is not happy. Depending on
>>>> who is responsible for the composite table tests, this could take some
>>>> time. Perhaps some days, perhaps some weeks.
>>>>
>>>> All that time, other widget changes cannot release because the build
>>>> breaks.
>>>>
>>>> If we have one build job per widget then the "release job" would always
>>>> just consume the latest successful build for any widget.
>>>>
>>>> Best regards,
>>>>
>>>> Wim
>>>>
>>>> [1] https://hudson.eclipse.org/hudson/job/maven-nebula-1.0-nightly/158/console
>>>>
>>>>
>>>> On Sat, Nov 19, 2011 at 1:52 AM, Tom Schindl
>>>> <tom.schindl@xxxxxxxxxxxxxxx <mailto:tom.schindl@xxxxxxxxxxxxxxx>> wrote:
>>>>
>>>>  Hi Wim,
>>>>
>>>>  Am 19.11.11 01:31, schrieb Wim Jongman:
>>>>> I think we need to create a build job per widget. If one widget fails
>>>>> for some reason, the complete build is invalid.
>>>>
>>>>  Well the one that breaks the build is responsible for fixing. I really
>>>>  don't think that it is pratical to have a build job for each widget.
>>>>
>>>>  Tom
>>>>
>>>>  --
>>>>  B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
>>>>  ------------------------------------------------------------------------
>>>>  tom schindl                 geschäftsführer/CEO
>>>>  ------------------------------------------------------------------------
>>>>  eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512
>>>>  935833 <tel:%2B%2B43%20512%20935833>
>>>>  http://www.BestSolution.at                      phone    ++43 512
>>>>  935834 <tel:%2B%2B43%20512%20935834>
>>>>  _______________________________________________
>>>>  nebula-dev mailing list
>>>>  nebula-dev@xxxxxxxxxxx <mailto:nebula-dev@xxxxxxxxxxx>
>>>>  https://dev.eclipse.org/mailman/listinfo/nebula-dev
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> nebula-dev mailing list
>>>> nebula-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/nebula-dev
>>>
>>>
>>> --
>>> B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
>>> ------------------------------------------------------------------------
>>> tom schindl                 geschäftsführer/CEO
>>> ------------------------------------------------------------------------
>>> eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512 935833
>>> http://www.BestSolution.at                      phone    ++43 512 935834
>>> _______________________________________________
>>> nebula-dev mailing list
>>> nebula-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/nebula-dev
>>
>> _______________________________________________
>> nebula-dev mailing list
>> nebula-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/nebula-dev
> _______________________________________________
> nebula-dev mailing list
> nebula-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/nebula-dev

_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev

_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev

Back to the top