Re: [nebula-dev] Gallery Widget Submission

[Christopher J Gross <chris.gross@xxxxxxxxxx>]

Awesome.  I didn't really expect
you to go make those changes so quickly.  I was just hoping to get
a commitment from you.  But even better!

I think this would be a great addition.
 

+1 from me.

-Chris

p.s.  If I might make a suggestion
about the renderer api... you have one draw method that takes a couple
of arguments including the bounds and the selected state.  If you
start adding other features to the class, you can't really keep adding
arguments without breaking any other renderer implementations.  I
would suggest you keep the draw method simple and add other state data
as properties (i.e. setSelected, getSelected).  That way if you add
more features you can just keep adding properties.

"nicolas richeton" <nicolas.richeton@xxxxxxxxx>
Sent by: nebula-dev-bounces@xxxxxxxxxxx

11/08/2006 02:08 AM

Please respond to
Nebula Dev <nebula-dev@xxxxxxxxxxx>

To	"Nebula Dev" <nebula-dev@xxxxxxxxxxx>
cc
Subject	Re: [nebula-dev] Gallery Widget Submission

Hi,

I made some changes on the widget as you suggested :
1 - Log 4j is removed
2 - jdk 1.4
3 - colors are disposed and I used system colors for background, foreground
and selection.
4 - addItem takes a GalleryItem as parameter getCount ->getItemCount
 : the other things are still to do. 
5 - Item drawing is now handled by a separate class which have to implement
IGalleryItemRenederer

I also improved drawing with a nice rounded rectangle around the image
when it is selected and item labels are now displayed. 

http://sharemedia.svn.sourceforge.net/viewvc/sharemedia/ShareMediaRCP/src/org/sharemedia/swt/widget/

Regards,
--
Nicolas

On 11/6/06, Christopher J Gross <chris.gross@xxxxxxxxxx>
wrote: 

Re 2.)  If they're contributions are small then they should be sent
to you through public channels (i.e. bugzilla, mailing list, etc).  This
is outlined in the committer guildelines from #1.  Filling out the
contribution questionnaire is only necessary if the contribution is significant.
 The employer consent form is only necessary if the contributor is
becoming a committer.  And then they would have to go through the
committer process.  I don't think we would need to give anyone other
than you commit rights. 

On to the code stuff... 

There are a couple of things in your widget that we would need to change
before we can get it into Nebula.   

1.) Can you remove log4j stuff.   In Nebula we are all about minimizing
dependencies.   

2.) Can you take the code down to at least jdk1.4?  Remove generics,
etc... 

3.) Make sure you dispose of your Colors.  (Don't override dispose,
use a dispose listener).  Also I would like to see your colors pulled
or derived from the system colors.  This way your widget will match
whatever OS theme the user is using. 

4.) Make Gallery#addItem default access.  Change the GalleryItem constructor
to take a Gallery instead of Composite.  Rename setCount to setItemCount.
 Javadoc.  etc.   This is small stuff that can be done later.
  

5.) I'd like to see some ability to custom draw the content of each item.
 This was mentioned on the newsgroup as well.  It seems like
it wouldn't be too difficult to retrofit something like this to the code.


1 & 2 are important and should be done before any code makes it to
Nebula.  The others aren't as important.  

Regards, 
-Chris

"nicolas richeton" <nicolas.richeton@xxxxxxxxx>
Sent by: nebula-dev-bounces@xxxxxxxxxxx

11/04/2006 11:27 AM

Please respond to
Nebula Dev <nebula-dev@xxxxxxxxxxx>

To	"Nebula Dev" <nebula-dev@xxxxxxxxxxx >
cc
Subject	Re: [nebula-dev] Gallery Widget Submission

Hi Chris,

1) I read the guidlines and I'm ok with them.

2) Yes, I'm the only author of this widget, I wrote it from scratch on
my free time. But there are other commiters in my project (
http://www.sf.net/projects/sharemedia) that
may want to make some improvements in the future. If they do, how can their
contributions be added ? I suppose they will have to follow the same process
( guidelines, employer consent) ? By the way, they are all working in the
same company than me, so I don't think there would be any problem. 

3) I already got the consent form signed by my employer, just in case :-)

Regards,
--
Nicolas 

On 11/3/06, Christopher J Gross < chris.gross@xxxxxxxxxx
> wrote: 

Hi Nicolas, 

First things first.  Please read the committer guidelines and confirm
that you understand them and can abide by them. 
http://www.eclipse.org/legal/committerguidelines.php

Second, I must verify that you have rights to contribute this code under
the EPL.  Are you the sole author of this code?  

Third, I must verify that your employer is willing to sign the Eclipse
committer consent form.  Essentially this clears the foundation from
any claims the employer might have on your contributions.  It sounds
like you've already talked to them and it sounds like they won't have a
problem.  Just to be sure, please run the consent form by them and
ensure they have no problem with it. 
http://www.eclipse.org/legal/employer_consent.pdf

After that we can get on to talking about the widgets.

Regards, 
-Chris

"nicolas richeton" <nicolas.richeton@xxxxxxxxx >
Sent by: nebula-dev-bounces@xxxxxxxxxxx

11/03/2006 04:24 AM

Please respond to
Nebula Dev <nebula-dev@xxxxxxxxxxx >

To	nebula-dev@xxxxxxxxxxx
cc
Subject	[nebula-dev] Gallery Widget Submission

Hi,

I'm currently working on an image gallery widget (see below for src and
screenshots) for my  RCP app. 

I'd like to contribute it to Nebula. 

The next features I plan to add to this widget are :
- Labels : display text along with images
- Groups : add the possibility to have groups that can expand/collapse.
- Horizontal scrolling : currently , this widget uses only a vertical scrolling.

(All these features are needed by my app) 

I checked that my employer is ok for me to contribute to Nebula.

Regards
--
Nicolas

Chris Gross wrote :
> I think its very cool.  If you're willing to donate and work
on it as 
> part of Nebula we'd be glad to have it.  The code seems nice
and 
> straightforward.  And I definitely think the world at large can
make use 
> of this type of listview-like widget.
> 
> If you'd like to contribute it to Nebula you should start by posting
a 
> message to the Nebula mailing list.
> 
> Regards,
> -Chris
> 
> Nicolas Richeton wrote:
>> Hi,
>>
>> I'm currently working on a photo sharing program based on RCP
for 
>> which I developped a gallery widget that displays a grid of Images
>> with shadows and auto margins.
>>
>> Screenshots can be found here :
>> http://sharemedia.free.fr/features.php?lang=en
>> Source code : 
>> http://sharemedia.svn.sourceforge.net/viewvc/sharemedia/ShareMediaRCP/src/org/sharemedia/swt/widget/

>>
>>
>> This widget has a Table-like API, both normal and virtual modes
are 
>> supported  (only the virtual mode is used in my app)
>>
>> There is still a lot of work to do, but this widget may be useful
to 
>> someone.
>>
>> Please let me know if you need more information.
>>
>> Thanks
>> -- 
>> Nicolas 
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev


_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev





-- 
--
Nicolas Richeton _______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev


_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev





-- 
--
Nicolas Richeton _______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev