| Re: [nebula-dev] Viewers |
|
Re: virtual tables Precalculate the size when you have different row heights? I'm not following. Virtual support doesn't necessarily relate to row heights. Currently, the Grid does not support different size rows. I've thought about adding that but it is a difficult feature. Simple calculations become more difficult when you have to take into account all the differing heights of the rows above. Re: viewers I definitely don't know what makes sense, but when I'm in similar situations I always look for that one use case that will show me if I'm going in the right direction. If I take a stab at it, I'd look at the spreadsheet-like cell selection in Grid. If you decided that could use some treatment in the viewer, what would that be? I don't see what would be worthwhile to add. Individual cells don't map to models easily. Anyway, all I'm saying is unless you can find at least one (at least) good reason to add something, don't. Just like when musicians say its not the notes that were played, its the ones that weren't: its not the code you wrote, its the code you didn't. Or something like that. -Chris Tom Schindl wrote: Yeah I'm following the thread. Back Virtual-Tables I ask myself how you could precalculate the size of your grid when it comes to different row heights. I think that's simply impossible, isn't it? Back to Viewers: Hopefully SWT-Team decides to provide a common interface for all those Table/Tree implementations still I'm not 100% whether JFace should provide a Layer above the SWT-Controls or not. Take the following situation: Maybe one of the underlying widgetsets provides something the SWT-Widget cannot provide because of what ever reason but JFace decides that I would like to give Widget implementators the possibility to do so if they want. Then JFace could provide Noop's as default implementation and Nebula could overwrite this by itself. Tom Christopher J Gross wrote:Hi Tom, Yes I'm aware of these differences. I was going to approach the virtual support to Grid in one big chunk. So I haven't implemented any of the relevant methods yet. On a related note, Steve N has given a ray of hope on 151644. So we may get a common base class after all. -Chris *Tom Schindl <listom@xxxxxxxxxxxxxxx>* Sent by: nebula-dev-bounces@xxxxxxxxxxx 08/07/2006 10:47 AM Please respond to Nebula Dev <nebula-dev@xxxxxxxxxxx> To Nebula Dev <nebula-dev@xxxxxxxxxxx> cc Subject Re: [nebula-dev] Viewers Hi Chris, I just created on my local computer a TableViewer-fork which is completely independent from SWT-Table and supports any Table-Widget following the SWT-Table-Interface and I found 2 Methods from Table who don't have corresponding counterparts in Grid: - setItemCount(); - clearAll(); I think it's very hard for grid to add support for the setItemCount() because the table's size can not be recalculated but the clearAll should not be that hard. Both are methods used with SWT.VIRTUAL. Tom Tom Schindl wrote:Oh yeah. This was the bug I meant. I already have a working version appended to https://bugs.eclipse.org/bugs/show_bug.cgi?id=149193 where rows and cells are wrapped. I think I'll discuss this with Tod and Boris in bug 149193 and how we could proceed to make JFace provide the proxies. At the moment my idea was to create an abstract wrapper class RowPart and implementors need provide the implementation. For projects JFace depends on namely SWT the Wrappers are provided by JFace itself other implementors like nebula have to provide them their own in the viewer project e.g. your NebFace. Tom Christopher J Gross schrieb:Hi Tom, Maybe you meant this bug? https://bugs.eclipse.org/bugs/show_bug.cgi?id=151644 As you can see its been decided against. It would be really great if JFace could provide a widget wrapper/proxy mechanism. I think having each widget developer create their own viewer is kinda redundant redundant. They would also almost certainly lag behind design and feature changes in the main JFace viewers. Does any of your existing patches contain this kind of wrapper feature? I do have plans to create a Nebula project with a JFace dependency (how bout NebFace?). Besides just viewers there could be other things like contribution managers too. -Chris *Tom Schindl <listom@xxxxxxxxxxxxxxx>* Sent by: nebula-dev-bounces@xxxxxxxxxxx 08/04/2006 10:30 AM Please respond to Nebula Dev <nebula-dev@xxxxxxxxxxx> To Nebula Dev <nebula-dev@xxxxxxxxxxx> cc Subject Re: [nebula-dev] Viewers Tom Schindl schrieb: |