Re: [nattable-dev] Find dialog improvements

[Hochstein Tom-R60874 <R60874@xxxxxxxxxxxxx>]

Hi Dirk,

 

Thanks for the reply. No problem on the delay, I know there is a release happening J

 

Yes, I would like to contribute my changes to SearchDialog.java.

 

9. Non-modal behavior: I thought to copy the implementation in FindReplaceAction. The key to this is to make the workbench part housing the NatTable adapt to some new API like IFindReplaceTarget, as you can see in FindReplaceAction.FindReplaceDialogStub.partActivated(). I think I may have overestimated the amount of API changes the other day when I tried to implement this, so today I will try again to implement this.

                                                                                        

6. Option ‘Column first’: I haven’t replaced GridSearchStrategy. The thing to know is that GridSearchStrategy does currently delegate to ColumnSearchStrategy. My proposal is to modify GridSearchStrategy to use either ColumnSearchStrategy or RowSearchStrategy depending on the ‘Column first’ option.

 

7. Option ‘Include hidden’: The problem of searching hidden cells is important for trees, which are implemented using hidden rows. In this case, the user will indeed expect the tree to open to a node containing his search text. I thought to keep the current behavior as an option so the user could search only in visible tree nodes.

 

I think you’re right though about the use of this in other cases, and that it’s not too useful to allow the user to search in columns that he’s hidden. Perhaps it’s best to limit the option to collapsed tree nodes instead, ‘Include hidden tree nodes’.

 

Thanks for your help.

 

Tom

                                                                                                                                                                                                              

From: Dirk Fauth [mailto:dirk.fauth@xxxxxxxxx]
Sent: Wednesday, September 26, 2012 2:09 AM
To: NatTable development mailing list
Cc: Hochstein Tom-R60874
Subject: Re: [nattable-dev] Find dialog improvements

 

Hi Tom,

sorry for the delay in answering. We are all quite busy at the moment. But in fact, I'm not sure what the question is. Are you planning to contribute your extension to NatTable?

I'm not that familiar with the SearchDialog, but regarding to your special options:

• Which API changes did you need to perform to get the non-modal behaviour working? (Seems to me an easy one, as only another SearchAction needs to be created and binded, and of course it needs to be checked that the command handler reacts on that)
• Option 6, allowing for a choice of RowSearchStrategy and ColumnSearchStrategy, how is it possible then to return to the GridSearchStrategy?
• Option 7, of which hidable content are you speaking? Hidden columns? Well if you don't want the ColumnHideShowLayer to be asked, you should use the DataLayer of the body to be the context layer for the SearchDialog. This brings of course some other issues, as then column reordering isn't asked also and so the resulting cell coordinates wouldn't fit the current NatTable presentation. In fact I'm not quite sure about the use case for searching hidden information. What should happen if a hidden information is found? Making it visible again? Selecting the whole row? Referring to the existing platform FindReplaceDialog you are only able to search for things that you can see.

As I'm not sure what the question is, I hope my questions regarding your modifications will help thinking about your issues. Otherwise please be more precise in asking so we are able to help. :)

Greez,

Dirk

 

On Tue, Sep 25, 2012 at 11:30 PM, Hochstein Tom-R60874 <R60874@xxxxxxxxxxxxx> wrote:

[Moving this from the forum.]

 

Hi All,

 

I'm working on extending SearchDialog.java to include the following items (using the platform FindReplaceDialog.java as reference):

 

1. Scope 'All'

2. Scope 'Selection’

3. Option 'Whole word'

4. Option 'Incremental'

5. Option 'Regular expressions'

6. Option ‘Column first’, allowing for a choice of RowSearchStrategy and ColumnSearchStrategy

7. Option ‘Include hidden’, enabled for NatTable stacks with hidable content

8. Dialog settings persistence

9. Non-modal

 

Comments and suggestions are welcome. I’ve got a working implementation for most of this, but  I couldn’t find a way to add 7. Option ‘Include hidden’ and 9. Non-modal behavior without some API changes.

                                                                                                                                                                           

Tom

 

_______________________________________________
nattable-dev mailing list
nattable-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/nattable-dev