Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-versions-dev] [mylyn-reviews-dev] find review items for git not working

Hi,

thanks for raising this. We are tracking the test failure on this task:

386736: ScmRepositoryTest.differentConnectorAreNotEqual() fails with
IllegalAccessError
https://bugs.eclipse.org/bugs/show_bug.cgi?id=386736

I have followed up on the task.

Steffen


On Fri, Aug 17, 2012 at 12:04 AM, Alvaro Sanchez <alvsan09@xxxxxxxxx> wrote:
> Hello,
>
> I have submitted a proposed fix to the Gerrit server for the issue below [1]
>      https://git.eclipse.org/r/#/c/7263/
>
> A text explanation of the update is also in the same bug [1]
>
> Take note that Hudson verification failed from a previously introduced
> change in the versions.test plug-in,
> Access Error as the test plugin is trying to access a protected method..
>   e.g. scmRepository.setConnector(connector)
>
> I can see a couple of options to solve the access error but would like to
> hear what others think about it.
>
> 1) Change the method to public
> 2) Change the test plug-in to fragment of the core plug-in
>
> /Alvaro
>
>
> [1] 386966: No commits are resolved if a project is also available from a
> wrap per project as a linked resource
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=386966
>
>
>
> On Thu, Aug 9, 2012 at 4:47 PM, Alvaro Sanchez <alvsan09@xxxxxxxxx> wrote:
>>
>> I have been able to reproduce the problem after the debug session with
>> David,
>> The issue is now tracked in the following bug
>>    https://bugs.eclipse.org/bugs/show_bug.cgi?id=386966
>>
>> David, thanks for bringing this up
>>
>> /Alvaro
>>
>>
>> On Tue, Aug 7, 2012 at 8:45 PM, David Medina <b2amedina@xxxxxxxxx> wrote:
>>>
>>> yes, I have one large java project with the complete android source tree
>>> ( see http://source.android.com/source/using-eclipse.html )
>>>
>>> I then have several other general projects (e.g. one per git repo) that
>>> overlaps with the directories in the java project
>>>
>>> I would be happy to gather debug info, or do a debug session with you if
>>> you want
>>>
>>> On Aug 7, 2012, at 5:12 PM, Alvaro Sanchez wrote:
>>>
>>> Hello David,
>>> This is most likely a bug under Mylyn versions git connector and possibly
>>> the same root cause as in [1]
>>>
>>> Would you please file a bug to mylyn versions git connector, see [2]
>>>
>>> We'll need to continue the investigation under this new bug,
>>>
>>> I suspect this issue is related to a commit filter in the Mylyn Versions
>>> Git connector UI,
>>> the intention of the filter is to only list commits which are related to
>>> the selected work space project,
>>> This is done by comparing the eclipse project path of the files under the
>>> commit against the selected project.
>>>   Some how after importing your projects the root of the file paths
>>> relative to the work space don't match the Eclipse project's relative path
>>>
>>> Could you please elaborate more when you say "have multiple projects that
>>> have the same directories"
>>> e.g. are you using linked resources from different projects pointing to
>>> the same physical folder ?
>>>
>>>
>>> /Alvaro
>>>
>>>
>>> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=381036
>>>
>>> [2] https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Mylyn%20Versions
>>>
>>>
>>> On Tue, Aug 7, 2012 at 2:06 PM, David Medina <b2amedina@xxxxxxxxx> wrote:
>>>>
>>>> Hello Alvaro,
>>>>
>>>> Thanks for getting back to me
>>>>
>>>> We don't import projects using maven, and we use both git and svn
>>>>
>>>> I am running on Eclipse indigo (see below for all my plug-ins)
>>>>
>>>> Mylyn Versions Connector: Git 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.git.feature.group Eclipse Mylyn
>>>>
>>>> I noticed that if I start with an empty workspace with no packages, them
>>>> import a git and svn project, find review items works correctly
>>>>
>>>> Unfortunately when I start adding my normal projects it suddenly stops
>>>> working. I don't know if it is because I have multiple projects that have
>>>> the same directories in them
>>>>
>>>> As a side note if I create a review and I add both git and svn items,
>>>> eclipse crashes with
>>>>
>>>> eclipse(78135,0x129fa8000) malloc: *** error for object 0x129dc7050:
>>>> pointer being freed was not allocated *** set a breakpoint in
>>>> malloc_error_break to debug
>>>>
>>>> ----------------------------------
>>>>
>>>>   Android DDMS 20.0.1.v201207132230-403220
>>>> com.android.ide.eclipse.ddms.feature.group The Android Open Source Project
>>>>   Android Development Tools 20.0.1.v201207132230-403220
>>>> com.android.ide.eclipse.adt.feature.group The Android Open Source Project
>>>>   Android Hierarchy Viewer 20.0.1.v201207132230-403220
>>>> com.android.ide.eclipse.hierarchyviewer.feature.group The Android Open
>>>> Source Project
>>>>   Android Native Development Tools 20.0.1.v201207132230-403220
>>>> com.android.ide.eclipse.ndk.feature.group The Android Open Source Project
>>>>   Android Traceview 20.0.1.v201207132230-403220
>>>> com.android.ide.eclipse.traceview.feature.group The Android Open Source
>>>> Project
>>>>   CollabNet Merge Client 3.0.9
>>>> com.collabnet.subversion.merge.feature.feature.group CollabNet
>>>>   Eclipse IDE for Java Developers 1.4.2.20120213-0813 epp.package.java
>>>> null
>>>>   Emacs+ 3.6.5 com.mulgasoft.emacsplus.feature.feature.group MulgaSoft
>>>>   Emacs+ Options 3.6.5
>>>> com.mulgasoft.emacsplus.optional.features.feature.group MulgaSoft
>>>>   EPIC 0.5.46 org.epic.feature.main.feature.group Epic Project
>>>>   Mylyn Builds 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.builds.feature.group Eclipse Mylyn
>>>>   Mylyn Builds Connector: Hudson/Jenkins 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.hudson.feature.group Eclipse Mylyn
>>>>   Mylyn Builds SDK 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.builds.sdk.feature.group Eclipse Mylyn
>>>>   Mylyn Commons 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.commons.feature.group Eclipse Mylyn
>>>>   Mylyn Commons Compatibility 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.commons.compatibility.feature.group Eclipse Mylyn
>>>>   Mylyn Commons Identity 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.commons.identity.feature.group Eclipse Mylyn
>>>>   Mylyn Commons Notifications 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.commons.notifications.feature.group Eclipse Mylyn
>>>>   Mylyn Commons Repositories 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.commons.repositories.feature.group Eclipse Mylyn
>>>>   Mylyn Commons Repositories HTTP Transport 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.commons.repositories.http.feature.group Eclipse Mylyn
>>>>   Mylyn Commons SDK 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.commons.sdk.feature.group Eclipse Mylyn
>>>>   Mylyn Context Connector: C/C++ Development 5.4.1.v20120725-0100
>>>> org.eclipse.cdt.mylyn.feature.group Eclipse Mylyn
>>>>   Mylyn Context Connector: Eclipse IDE 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.ide_feature.feature.group Eclipse Mylyn
>>>>   Mylyn Context Connector: Java Development 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.java_feature.feature.group Eclipse Mylyn
>>>>   Mylyn Context Connector: Plug-in Development 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.pde_feature.feature.group Eclipse Mylyn
>>>>   Mylyn Context Connector: Team Support 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.team_feature.feature.group Eclipse Mylyn
>>>>   Mylyn Context SDK 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.context.sdk.feature.group Eclipse Mylyn
>>>>   Mylyn Docs EPUB 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.docs.epub.feature.group Eclipse Mylyn
>>>>   Mylyn Docs SDK 1.7.1.v20120725-0100
>>>> org.eclipse.mylyn.docs.sdk.feature.group Eclipse Mylyn
>>>>   Mylyn EPUB SDK 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.docs.epub.sdk.feature.group Eclipse Mylyn
>>>>   Mylyn HtmlText 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.htmltext.feature.group Eclipse Mylyn
>>>>   Mylyn Reviews 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.reviews.feature.feature.group Eclipse Mylyn
>>>>   Mylyn Reviews Connector: Gerrit 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.gerrit.feature.feature.group Eclipse Mylyn
>>>>   Mylyn Reviews for Eclipse: R4E (Incubation) 0.11.0.v20120712-1500
>>>> org.eclipse.mylyn.reviews.r4e.feature.feature.group Eclipse Mylyn
>>>>   Mylyn Reviews R4E Connector: Reporting (Incubation)
>>>> 0.11.0.v20120712-1500 org.eclipse.mylyn.reviews.r4e.reports.feature.group
>>>> Eclipse Mylyn
>>>>   Mylyn Reviews R4E Installation Guide (Incubation)
>>>> 0.11.0.v20120712-1500
>>>> org.eclipse.mylyn.reviews.r4e.help.install.feature.feature.group Eclipse
>>>> Mylyn
>>>>   Mylyn Reviews R4E SDK (Incubation) 0.11.0.v20120712-1500
>>>> org.eclipse.mylyn.reviews.r4e.sdk.feature.feature.group Eclipse Mylyn
>>>>   Mylyn Reviews SDK 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.reviews.sdk.feature.feature.group Eclipse Mylyn
>>>>   Mylyn Task List 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn_feature.feature.group Eclipse Mylyn
>>>>   Mylyn Task-Focused Interface 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.context_feature.feature.group Eclipse Mylyn
>>>>   Mylyn Tasks Connector: Bugzilla 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.bugzilla_feature.feature.group Eclipse Mylyn
>>>>   Mylyn Tasks Connector: Eclipse IDE 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.tasks.ide.feature.group Eclipse Mylyn
>>>>   Mylyn Tasks Connector: Trac 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.trac_feature.feature.group Eclipse Mylyn
>>>>   Mylyn Tasks SDK 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.sdk_feature.feature.group Eclipse Mylyn
>>>>   Mylyn Tasks Tests SDK 3.8.1.v20120725-0100
>>>> org.eclipse.mylyn.test_feature.feature.group null
>>>>   Mylyn Versions 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.versions.feature.group Eclipse Mylyn
>>>>   Mylyn Versions Connector: CVS 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.cvs.feature.group Eclipse Mylyn
>>>>   Mylyn Versions Connector: Git 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.git.feature.group Eclipse Mylyn
>>>>   Mylyn Versions Connector: Subclipse 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.subclipse.feature.group Eclipse Mylyn
>>>>   Mylyn Versions SDK 1.0.1.v20120725-0100
>>>> org.eclipse.mylyn.versions.sdk.feature.group Eclipse Mylyn
>>>>   Mylyn WikiText 1.7.1.v20120725-0100
>>>> org.eclipse.mylyn.wikitext_feature.feature.group Eclipse Mylyn
>>>>   Mylyn WikiText SDK 1.7.1.v20120725-0100
>>>> org.eclipse.mylyn.wikitext.sdk.feature.group Eclipse Mylyn
>>>>   ShellEd 2.0.2 net.sourceforge.shelled.feature.group null
>>>>   Subclipse (Required) 1.8.14
>>>> org.tigris.subversion.subclipse.feature.group tigris.org
>>>>   Subclipse Integration for Mylyn 3.x (Optional) 3.0.0
>>>> org.tigris.subversion.subclipse.mylyn.feature.group tigris.org
>>>>   Subversion Client Adapter (Required) 1.8.3
>>>> org.tigris.subversion.clientadapter.feature.feature.group tigris.org
>>>>   Subversion JavaHL Native Library Adapter 1.7.5.2
>>>> org.tigris.subversion.clientadapter.javahl.feature.feature.group tigris.org
>>>>   Subversion Revision Graph 1.1.1
>>>> org.tigris.subversion.subclipse.graph.feature.feature.group tigris.org
>>>>
>>>> On Aug 7, 2012, at 10:06 AM, Alvaro Sanchez wrote:
>>>>
>>>>
>>>>
>>>> ---------- Forwarded message ----------
>>>> From: Alvaro Sanchez <alvsan09@xxxxxxxxx>
>>>> Date: Tue, Aug 7, 2012 at 10:05 AM
>>>> Subject: Re: [mylyn-reviews-dev] find review items for git not working
>>>> To: Mylyn Reviews Project <mylyn-reviews-dev@xxxxxxxxxxx>
>>>>
>>>>
>>>> Hello David,
>>>> The symptoms seem to be similar to the issue tracked in [1],  which
>>>> fortunately has a work around.
>>>> could you confirm if you are importing maven projects using m2e-egit ?
>>>>
>>>> What version of "Mylyn Reviews for Eclipse R4E" and "Mylyn Versions
>>>> Connector: Git" are you using ?
>>>> Help -> About Eclipse SDK -> Installation Details -> Installed Software
>>>>
>>>> /Alvaro
>>>>
>>>> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=381036
>>>>
>>>>
>>>>
>>>> On Mon, Aug 6, 2012 at 12:57 PM, David Medina <b2amedina@xxxxxxxxx>
>>>> wrote:
>>>>>
>>>>> I have both git and svn configured for r4e
>>>>>
>>>>> When I do a "find review items" for svn everything works as expected
>>>>>
>>>>> But for git, it comes back with a dialog with no commits (see attached
>>>>> image) even though there are several and "team->show in history" works fine
>>>>>
>>>>> Is there something else that I need to do to get this to work?
>>>>>
>>>>>
>>>>>
>>>>> Regards,
>>>>>
>>>>> David Medina
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> mylyn-reviews-dev mailing list
>>>>> mylyn-reviews-dev@xxxxxxxxxxx
>>>>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>>>>>
>>>>
>>>>
>>>>
>>>> Regards,
>>>>
>>>> David Medina
>>>>
>>>>
>>>>
>>>
>>>
>>> Regards,
>>>
>>> David Medina
>>>
>>>
>>>
>>
>
>
> _______________________________________________
> mylyn-versions-dev mailing list
> mylyn-versions-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/mylyn-versions-dev
>



-- 
Steffen Pingel
Principal Software Engineer, Eclipse Mylyn
Mylyn Tasks Lead
http://tasktop.com


Back to the top