Re: [mylyn-versions-dev] Initial git version connector implementation

[Steffen Pingel <steffen.pingel@xxxxxxxxxxx>]

Hi,

the proposed API sounds fine with me. The Team API offers similar mechanisms to look up providers. Please feel free to file a bug if you want to go ahead with implementing that.

I don't foresee though that the Versions project would be providing a generic storage API. Any reason why you wouldn't directly couple to the JGit API for the purpose you described? 

You could also considered building on one of the projects that provide persistence for EMF models or generic persistence mechanisms beyond what is available in the JDK, e.g.:

 http://wiki.eclipse.org/CDO
 http://www.eclipse.org/proposals/emf-store/
 http://jackrabbit.apache.org/

Steffen

On Tue, Feb 22, 2011 at 3:21 PM, alvaro sanchez <alvsan09@xxxxxxxxx> wrote:

Hello,
the Mylyn versions is looking good with base functionality for cvs and git,

I would like your opinion on the following:
The current implementation is based on resolving the connector and
repo from IResource,
this makes a lot of sense for the normal cases.
 In R4E, we are looking at the possibility to have an internal jgit
repo to store copies of the base and target files within a change..  I
would like if possible, to use Mylyn versions project to manage this
internal repository in addition to the ones related to reviews.

to gain access to the connector we can add to ScmCore:
 e.g. make public existing getScmConnectorById(String id)
  I don't like this one since the user app needs to the specific id,
any  other ideas ?

To gain access to the connector we could add in ScmConnector e.g.
   ScmRepository getRepository(URI fileUri, IProgressMonitor monitor)

Do you think the above changes are in line with the scope envisioned
for Mylyn versions ?

Best Regards
/Alvaro

On Mon, Feb 14, 2011 at 5:36 PM, Steffen Pingel
<steffen.pingel@xxxxxxxxxxx> wrote:
> That's great! Do you think we'll be able to include that in the 0.7 release?
> And do you think we could get the same compare functionality working that we
> have for CVS to enable navigating from Hudson builds to Git files?
>
> Steffen
>
>
> On Thu, Feb 3, 2011 at 3:20 PM, Kilian Matt <kilian.matt@xxxxxxxxxxxxxxxxx>
> wrote:
>>
>> Hi,
>>
>> I've just commited an initial implementation of the git connector.
>> (Bug 336293 [1]).
>> It's currently just providing some basic functionality, which I need
>> for the changeset based reviewing in TBR.
>>
>> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=336293
>>
>> Kilian
>> _______________________________________________
>> mylyn-versions-dev mailing list
>> mylyn-versions-dev@xxxxxxxxxxx
>> http://dev.eclipse.org/mailman/listinfo/mylyn-versions-dev
>
>
>
> --
> Steffen Pingel
> Committer, http://eclipse.org/mylyn
> Senior Developer, http://tasktop.com
>
> _______________________________________________
> mylyn-versions-dev mailing list
> mylyn-versions-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/mylyn-versions-dev
>
>
_______________________________________________
mylyn-versions-dev mailing list
mylyn-versions-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/mylyn-versions-dev

-- 
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com