[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [mylyn-reviews-dev] Migrating to Mylyn Reviews 2.0
|
Hi Miles,
On Fri, Sep 6, 2013 at 1:52 AM, Miles Parker <miles.parker@xxxxxxxxxxx> wrote:
>
> Hi Robert,
>
> I hope the changes aren't too painful!
Don't seem to be, I hope to spend just a couple of hours in porting +
testing. Your help is much appreciated.
>
> 1. We've removed ITopic altogether. The thinking was that we always had a 1:1 between IComment and ITopic and they contained exactly the same information! I believe that that was there to support some of the features of R4E which they no longer need either. I hope you weren't using them for a more complex relationship, but I think that that the old approach would have had to be revisited anyway. See https://git.eclipse.org/r/#/c/12217/
Nope, that change makes sense and adapting was easy.
>
> 2. IFileRevision is now IFileVersion, See https://git.eclipse.org/r/#/c/11871/
OK, I adapted to that as well. I noticed that I know have to supply a
typed IFileRevision. Again, makes sense, I was passing Strings to my
scm-specific layer.
After some find/replace I have one more question
3. ILineLocation.getTotal{Min,Max} have been replaced by
getRange{Min,Max}. Are these drop-in replacements?
Thanks!
Robert
>
> cheers,
>
> Miles
>
> On 2013-09-05, at 3:35 PM, Robert Munteanu <robert.munteanu@xxxxxxxxx> wrote:
>
>> Hi,
>>
>> I'm looking to migrate the eReviewBoard connector to build/run against
>> Mylyn Reviews 2.0.
>>
>> When switching the target platform I see that ITopic and IFileRevision
>> are gone. What are the replacements for those?
>>
>> Thanks,
>>
>> Robert
>> --
>> http://robert.muntea.nu/
>> _______________________________________________
>> mylyn-reviews-dev mailing list
>> mylyn-reviews-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>
> _______________________________________________
> mylyn-reviews-dev mailing list
> mylyn-reviews-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
--
http://robert.muntea.nu/
