[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[mylyn-reviews-dev] Common Model Changes
|
Okay, here it is, the big kahuna:
https://github.com/Tasktop/mylyn.reviews.r4e/commit/2a000dfb4345af453900a031828d9307d6c25167
Actually, you might not want to click that link unless you are looking to load test your browser. :D
This is the relevant branch: bug324327 https://github.com/Tasktop/mylyn.reviews.r4e/tree/bug324327CommonModel.
The diffs are much better, but there are still a lot of spurious changes like for different formatting on comments, and even if all of the changes were legit, it would still be a huge commit. Just as one example, every usage of a reviews.core interface has changed from MyClass to IMyClass.
Speaking of that, I've made that change to the reviews core, but not yet to the R4E code base…that's the next big change step -- may push that one today as well. If anyone has a big problem with adopting the Eclipse/Java style for interfaces and implementations over the default EMF codegen approach let me know...
Thanks to R4E team for getting the other changes I needed done I'm going to keep working off of these changes and refining things. Let's review on the new Common Model review I created on the Google Drive. It's nice to be able to separate out the reviews from the commits!
cheers,
Miles
