Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-reviews-dev] Reviews Tasks DSL antrl dependency

Yeah, r.t.core is dependent on it unfortunately. Speaking of, now I'm curious about the history here.

Don't know if Matt Killian is still an active contributor (?), but wondering why the xtext implementation was replaced with Antlr? More importantly, where did the grammar go?! :) It looks like it should be in a file called "ReviewDsl.g", but I don't see that or anything else in the project and it doesn't seem to have been contributed along with 35c49ea2db324c527a45be9a219cc05f2a718950.

On 2012-09-11, at 3:45 PM, Steffen Pingel <steffen.pingel@xxxxxxxxxxx> wrote:

> The use of that particular antlr version is intentional to my knowledge. If you don't want to consume that bundle from the old repository I would recommend closing the tbr bundles.
> 
> Steffen 
> 
> 
> On Tue, Sep 11, 2012 at 3:39 PM, Miles Parker <miles.parker@xxxxxxxxxxx> wrote:
> Hi all,
> 
> I'm trying to put a reviews build together and ran into a dependency issue with o.e.m.reviews.tasks.dsl. DSL wants 3.0.0 explicitly:
> 
> Import-Package: org.antlr.runtime;version="[3.0.0,3.1.0)",
> org.antlr.runtime.tree;version="[3.0.0,3.1.0)"
> 
> And the Current Orbit drop only supplies 3.2.0. And in fact, modifying tasks.dsl to consume 3.2.0 results in compilation exceptions. What I ended up doing was consuming from two orbit sites, see below. But that's not very maintainable.
> 
> Does anyone have any insight or background on this? I can raise a bug but thought I'd check here first.
> 
> cheers,
> 
> Miles
> 
> <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
> <unit id="org.antlr.runtime" version="3.0.0.v200803061811"/>
> <unit id="com.google.guava.source" version="10.0.1.v201203051515"/>
> <unit id="com.google.guava" version="10.0.1.v201203051515"/>
> <unit id="com.google.gerrit.common" version="0.0.0"/>
> <unit id="com.google.gerrit.common.source" version="0.0.0"/>
> <unit id="com.google.gerrit.prettify" version="0.0.0"/>
> <unit id="com.google.gerrit.prettify.source" version="0.0.0"/>
> <unit id="com.google.gerrit.reviewdb" version="0.0.0"/>
> <unit id="com.google.gerrit.reviewdb.source" version="0.0.0"/>
> <unit id="org.hamcrest.core" version="0.0.0"/>
> <unit id="org.hamcrest.core.source" version="0.0.0"/>
> <unit id="org.hamcrest.integration.source" version="0.0.0"/>
> <unit id="org.hamcrest.generator" version="0.0.0"/>
> <unit id="org.hamcrest.generator.source" version="0.0.0"/>
> <unit id="org.hamcrest.integration" version="0.0.0"/>
> <unit id="org.hamcrest.library" version="0.0.0"/>
> <unit id="org.hamcrest.library.source" version="0.0.0"/>
> <unit id="org.hamcrest" version="0.0.0"/>
> <unit id="org.hamcrest.text" version="0.0.0"/>
> <unit id="org.hamcrest.text.source" version="0.0.0"/>
> <unit id="org.objenesis.source" version="0.0.0"/>
> <unit id="org.objenesis" version="0.0.0"/>
> <unit id="org.mockito" version="0.0.0"/>
> <unit id="org.mockito.source" version="0.0.0"/>
> <unit id="org.apache.commons.io" version="0.0.0"/>
> <unit id="org.apache.commons.logging" version="0.0.0"/>
> <repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20120526062928/repository/"/>
> </location>
> <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
> <unit id="org.antlr.runtime" version="3.0.0.v200803061811"/>
> <repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20120119162704/repository/"/>
> </location>
> 
> 
> _______________________________________________
> mylyn-reviews-dev mailing list
> mylyn-reviews-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
> 
> 
> 
> -- 
> Steffen Pingel
> Principal Software Engineer, Eclipse Mylyn
> Mylyn Tasks Lead
> http://tasktop.com
> _______________________________________________
> mylyn-reviews-dev mailing list
> mylyn-reviews-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev



Back to the top