Re: [mylyn-reviews-dev] Changing the icon for comment annotations in the

[Robert Munteanu <robert.munteanu@xxxxxxxxx>]

On Wed, Oct 12, 2011 at 4:05 PM, Steffen Pingel
<steffen.pingel@xxxxxxxxxxx> wrote:
> The ruler extension is provided by the reviews framework and hence
> intentionally uses the generic icon which is specified in the plugin.xml of
> the o.e.m.review.ui bundle. I wouldn't recommend using a branded icon for
> rulers and markers to avoid inconsistencies between reviews connectors and
> to avoid confusion about the meaning of the icon. The early versions of the
> Gerrit connector used the branding icon as a placeholder since we didn't
> have a better icon, yet. Does that make sense?
> Steffen

Yes, that makes perfect sense. I was under the impression that I
missed an extension point somewhere due to the Gerrit screenshots.

Thanks,

Robert

>
>
> On Wed, Oct 12, 2011 at 3:01 PM, Steffen Pingel <steffen.pingel@xxxxxxxxxxx>
> wrote:
>>
>> The latest weeky build should be using a generic glasses icon for markers:
>>  344107: decorate gerrit tasks with review icon
>>  https://bugs.eclipse.org/bugs/show_bug.cgi?id=344107
>> Please feel free to file a bug if that doesn't work for you.
>> Thanks,
>> Steffen
>>
>> On Wed, Oct 12, 2011 at 10:52 AM, Robert Munteanu
>> <robert.munteanu@xxxxxxxxx> wrote:
>>>
>>> Hi,
>>>
>>> The Gerrit screenshots at http://www.eclipse.org/mylyn/new/#gerrit
>>> show a gerrit icon in the compare editor . However , in my
>>> implementation I only manage to get a generic reviews icon . I was
>>> unable to find an extension point to change this icon. I do have a
>>> brandingIcon defined for my repository connector, but that seems to
>>> make no difference.
>>>
>>> How can I change the icon in the compare editor?
>>>
>>> Thanks,
>>>
>>> Robert
>>>
>>> --
>>> Sent from my (old) computer
>>> _______________________________________________
>>> mylyn-reviews-dev mailing list
>>> mylyn-reviews-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>>
>>
>>
>> --
>> Steffen Pingel
>> Committer, http://eclipse.org/mylyn
>> Senior Developer, http://tasktop.com
>
>
>
> --
> Steffen Pingel
> Committer, http://eclipse.org/mylyn
> Senior Developer, http://tasktop.com
>
> _______________________________________________
> mylyn-reviews-dev mailing list
> mylyn-reviews-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>
>



-- 
Sent from my (old) computer