Re: [mylyn-reviews-dev] Making use of the support classes from org.eclip

[Steffen Pingel <steffen.pingel@xxxxxxxxxxx>]

The implementation in org.eclipse.mylyn.reviews.ui is intended as a generic framework and should be reusable as you described. You will also need to provide an implementation of ReviewBehavior to handle interactions such adding of comments.

Note that the Gerrit connector is the only RI at this point and the framework is still work in progress. Please feel free to file bugs if you have any feedback or suggestions for improvement.

Out of curiosity, what are you building that integrates with the Reviews framework?

Cheers,

Steffen

On Mon, Oct 10, 2011 at 2:51 PM, Robert Munteanu <robert.munteanu@xxxxxxxxx> wrote:

Hi,

I've noticed the recent improvements regarding opening remote changes
in the Compare editor and displaying inline comments which were
brought to the Gerrit connector.

I've checked out the project and saw that most of the UI was provided
in the org.eclipse.mylyn.reviews.ui bundle. For instance, in
org.eclipse.mylyn.internal.gerrit.ui.editor.PatchSetSection I see that
the compare UI takes as input IFileItem instances which are then
passed to an ReviewCompareAnnotationModel.

This leads me to believe that if I wanted to build on this compare UI
support I would need to construct IFileItems from for my change sets
and pass them to a ReviewCompareAnnotationModel .
Is that correct or should I do anything else?

Thanks,

Robert

--
Sent from my (old) computer
_______________________________________________
mylyn-reviews-dev mailing list
mylyn-reviews-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev

--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com