Re: [mylyn-reviews-dev] Reviews build broken?

[Steffen Pingel <steffen.pingel@xxxxxxxxxxx>]

Looks like Maven fixed itself.

Steffen

On Thu, Sep 1, 2011 at 4:21 PM, Sebastien Dubois <sebastien.dubois@xxxxxxxxxxxx> wrote:

Ok I made the changes and it seems that it fixed the build at that time.  However I see that last night's run still failed.

---

From: mylyn-reviews-dev-bounces@xxxxxxxxxxx [mailto:mylyn-reviews-dev-bounces@xxxxxxxxxxx] On Behalf Of Sebastien Dubois
Sent: August 31, 2011 3:41 PM

To: Mylyn Reviews Project
Subject: Re: [mylyn-reviews-dev] Reviews build broken?

Yes the builds are most likely failing now because jdt and cdt are marked optional in R4E.  I'll make the relevant changes.

 

Thx,

/Sebas

---

From: mylyn-reviews-dev-bounces@xxxxxxxxxxx [mailto:mylyn-reviews-dev-bounces@xxxxxxxxxxx] On Behalf Of Steffen Pingel
Sent: August 31, 2011 3:31 PM
To: Mylyn Reviews Project
Subject: Re: [mylyn-reviews-dev] Reviews build broken?

It might be a problem specific to hudson.eclipse.org. I have cleaned the workspace and triggered a new build in the hope that it will fix the Maven exception.

If I run the build locally I still get compile errors:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.13.0-SNAPSHOT:compile (default-compile) on project org.eclipse.mylyn.reviews.r4e.ui: Compilation failure: Compilation failure:

[ERROR] /home/spingel/mylyn/src/org.eclipse.mylyn.reviews/r4e/org.eclipse.mylyn.reviews.r4e.ui/src/org/eclipse/mylyn/reviews/r4e/ui/internal/utils/CommandUtils.java (at line 37):[-1,-1]

[ERROR] import org.eclipse.jdt.core.IJavaElement;

[ERROR] ^^^^^^^^^^^^^^^

[ERROR] The import org.eclipse.jdt cannot be resolved

Note that you now need to list optional dependencies in the build.properties in the jars.extra.classpath attribute (or mark them greedy). More details are on bug 355963.

To verify, you can always run the build locally from the org.eclipse.mylyn.reviews directory using Maven 3: mvn clean verify --fae

Steffen

On Wed, Aug 31, 2011 at 9:08 PM, Sebastien Dubois <sebastien.dubois@xxxxxxxxxxxx> wrote:

 Hi,

 Yesterday I had introduced a bug that caused the build to fail.  While repairing this, I noticed that the build is still broken with the following error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:2.4.1:resources (default-resources) on project org.eclipse.mylyn.reviews.core: Execution default-resources of goal org.apache.maven.plugins:maven-resources-plugin:2.4.1:resources failed: Unable to load the mojo 'resources' in the plugin 'org.apache.maven.plugins:maven-resources-plugin:2.4.1'. A required class is missing: org/apache/maven/shared/filtering/MavenFilteringException


I don't think this is related to the fix I've made, as the build doesn't even reach the point where it is compiled.

Is this related to the changes that were made with Tycho?

Thx,
/Sebastien
_______________________________________________
mylyn-reviews-dev mailing list
mylyn-reviews-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev

--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com

_______________________________________________
mylyn-reviews-dev mailing list
mylyn-reviews-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev

--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com