Re: [mylyn-reviews-dev] r4e compilation problem

[alvaro sanchez <alvsan09@xxxxxxxxx>]

Done, the code is restored.. and as expected the build is broken again ;-)

Thanks
/Alvaro

On Mon, Apr 4, 2011 at 3:00 AM, Steffen Pingel
<steffen.pingel@xxxxxxxxxxx> wrote:
> This build is failing due to the reverted commit. Please let me know
> when a fix has been pushed to the master and I'll trigger a new build.
>
> Steffen
>
>
> [ERROR] Failed to execute goal
> org.sonatype.tycho:maven-osgi-compiler-plugin:0.10.0:compile
> (default-compile) on project org.eclipse.mylyn.reviews.r4e.ui:
> Compilation failure: Compilation failure:
> [ERROR] /opt/users/hudsonbuild/workspace/mylyn-release/org.eclipse.mylyn.reviews/r4e/org.eclipse.mylyn.reviews.r4e.ui/src/org/eclipse/mylyn/reviews/r4e/ui/commands/FindReviewItemsHandler.java
> (at line 58):[-1,-1]
> [ERROR] import org.eclipse.mylyn.versions.ui.spi.ScmUiException;
> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ERROR] The import org.eclipse.mylyn.versions.ui.spi.ScmUiException
> cannot be resolved
> [ERROR]
> [ERROR] /opt/users/hudsonbuild/workspace/mylyn-release/org.eclipse.mylyn.reviews/r4e/org.eclipse.mylyn.reviews.r4e.ui/src/org/eclipse/mylyn/reviews/r4e/ui/commands/FindReviewItemsHandler.java
> (at line 128):[-1,-1]
> [ERROR] } catch (final ScmUiException e) {
> [ERROR] ^^^^^^^^^^^^^^
> [ERROR] ScmUiException cannot be resolved to a type
>
>
>
> On Sun, Apr 3, 2011 at 11:31 PM, Steffen Pingel
> <steffen.pingel@xxxxxxxxxxx> wrote:
>> I have triggered a new weekly build:
>> https://hudson.eclipse.org/hudson/job/mylyn-release/95/ .
>>
>> Steffen
>>
>>
>> On Sun, Apr 3, 2011 at 7:47 PM, alvaro sanchez <alvsan09@xxxxxxxxx> wrote:
>>> Hello Steffen,
>>> It seems we have a problem with the nightly build configuration, we
>>> seem to be picking an older version of the o.e.mylyn.versions.ui.
>>>  would you know where can we adjust this to follow HEAD ?
>>>
>>> Regards
>>> /Alvaro
>>>
>>>
>>> ---------- Forwarded message ----------
>>> From: Sebastien Dubois <sebastien.dubois@xxxxxxxxxxxx>
>>> Date: Sat, Apr 2, 2011 at 10:56 PM
>>> Subject: RE: r4e compilation problem
>>> To: Sascha Scholz <sascha.scholz@xxxxxxxxx>
>>> Cc: "alvsan09@xxxxxxxxx" <alvsan09@xxxxxxxxx>
>>>
>>>
>>>
>>> Hi Sasha,
>>>
>>>  This is weird,  the new ScmUiConnector#getChangeSet(ScmRepository,
>>> IResource, IProgressMonitor) does throw the CoreException, not the
>>> ScmUIException.  I think Alvaro did push that change to the mylyn
>>> versions project recently so everything should compile.
>>>
>>>  Is it possible that we are *somewhat* using an old version of Mylyn
>>> versions in the build?
>>>
>>> Alvaro:  Can you versify that your latest change was indeed pushed to
>>> the CVS repo that contains the mylyn versions project?
>>>
>>> In any case the original code is correct so we will have to revert your commit.
>>>
>>> BR,
>>> /Sebas
>>>
>>>
>>> -----Original Message-----
>>> From: Sascha Scholz [mailto:sascha.scholz@xxxxxxxxx]
>>> Sent: April 2, 2011 4:18 PM
>>> To: alvsan09@xxxxxxxxx; Sebastien Dubois
>>> Subject: r4e compilation problem
>>>
>>> Hello Alvaro, Sebastien,
>>>
>>> since a few days the mylyn-reviews-nightly Hudson builds were failing.
>>> The error was
>>>
>>> [ERROR] Failed to execute goal
>>> org.sonatype.tycho:maven-osgi-compiler-plugin:0.10.0:compile
>>> (default-compile) on project org.eclipse.mylyn.reviews.r4e.ui:
>>> Compilation failure: Compilation failure:
>>> [ERROR] /opt/users/hudsonbuild/workspace/mylyn-reviews-nightly/r4e/org.eclipse.mylyn.reviews.r4e.ui/src/org/eclipse/mylyn/reviews/r4e/ui/commands/FindReviewItemsHandler.java
>>> (at line 112):[-1,-1]
>>> [ERROR] changeSet = uiConnector.getChangeSet(null, project, null);
>>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>> [ERROR] Unhandled exception type ScmUiException [ERROR] [ERROR]
>>> /opt/users/hudsonbuild/workspace/mylyn-reviews-nightly/r4e/org.eclipse.mylyn.reviews.r4e.ui/src/org/eclipse/mylyn/reviews/r4e/ui/commands/FindReviewItemsHandler.java
>>> (at line 114):[-1,-1]
>>> [ERROR] } catch (CoreException e) {
>>> [ERROR] ^^^^^^^^^^^^^
>>> [ERROR] Unreachable catch block for CoreException. This exception is
>>> never thrown from the try statement body [ERROR] -> [Help 1]
>>>
>>> To get the build running again I pushed
>>> http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.reviews.git/commit/?id=a93a5e34a99028e5a6c1dc7dac9bb440e34e938a.
>>> Unfortunately, the Eclipse formatter did some extra work, hiding the
>>> actually small change
>>>
>>> - } catch (CoreException e) {
>>> + } catch (final ScmUiException e) {
>>>
>>> Feel free to revert my commit.
>>>
>>> Sascha
>>>
>>
>>
>>
>> --
>> Steffen Pingel
>> Committer, http://eclipse.org/mylyn
>> Senior Developer, http://tasktop.com
>>
>
>
>
> --
> Steffen Pingel
> Committer, http://eclipse.org/mylyn
> Senior Developer, http://tasktop.com
>