Re: [mylyn-reviews-dev] Model in gerrit connector bundles

["Lohre, Jan" <jan.lohre@xxxxxxx>]

I agree that TaskData will not be optimal for all data of the gerrit connector.

But I think we should not start with a "framework" model at the moment. We will have to see what the different review systems have in common and then abstract over that. 
E.g. (and this is really just an arbitrary example that got my immediate attention) FileRevision does not really make sense for git based reviews.

Not that there is nothing to share, but for the moment the commonalities are IMHO sparse.

On the other hand I still have to get into the existing code base.

Cheers,
Jan
-----Original Message-----
From: mylyn-reviews-dev-bounces@xxxxxxxxxxx [mailto:mylyn-reviews-dev-bounces@xxxxxxxxxxx] On Behalf Of Steffen Pingel
Sent: Freitag, 21. Januar 2011 21:51
To: Mylyn Reviews Project
Subject: Re: [mylyn-reviews-dev] Model in gerrit connector bundles

I'll post summarize on to the bug later today what motivated the current design.

 324327: Define a common model for reviews
 https://bugs.eclipse.org/bugs/show_bug.cgi?id=324327

On a high level, my sense is that TaskData is not a good match to
store the Gerrit Connector or review content in general. I think we
are best of limiting its use to task list integration and basic task
editor integration. From my experience, EMF offers much more powerful
capabilities (e.g. compare, merge, notifiactions...) and encapsulates
common concerns in the framework such as persistence that you have to
deal with otherwise.

Steffen


On Fri, Jan 21, 2011 at 11:22 AM, Lohre, Jan <jan.lohre@xxxxxxx> wrote:
> Just noticed the model reviews.ecore in the core bundle of the gerrit
> connector.
> I don't like the idea of using EMF in the gerrit connector very much - we
> that have to map between gerrit and Mylyn TaskData and between TaskData and
> the model, don't we? What do we gain?
> Furthermore a very similar model exists in reviews framework.
>
> What do you think?
>
> Cheers,
> Jan
>
>
> _______________________________________________
> mylyn-reviews-dev mailing list
> mylyn-reviews-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>
>



-- 
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com
_______________________________________________
mylyn-reviews-dev mailing list
mylyn-reviews-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev