[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [mylyn-reviews-dev] org.eclipse.reviews.frame.core model
|
On Wed, Nov 24, 2010 at 7:49 AM, alvaro sanchez <alvsan09@xxxxxxxxx> wrote:
> While we are discussing this... the API in org.eclipse.reviews.frame.core
> exposes EMF types. Is that intentional? It could make sense as clients are
> likely to extend the model but I was wondering if that has been discussed?
> Alvaro: The core model is meant to be extended (few entities are abstract).
> However I am not sure I understand which elements cause the concern, as all
> model elements are returned with the type of an interface by the factory.
I was more thinking from an API perspective. Exposing EMF types
couples the Reviews API to EMF and I find that it adds some "clutter".
I guess we can leave it for now and revisit for the 1.0 release.
> What about concurrent access to the model? EMF is not inherently thread
> safe. Is there a bug for addressing this, e.g. through EMF Transactions?
> Alvaro: Since the model is meant to be extended, I would assume the extended
> model would need to address thread safety and other recovery mechanisms e.g.
> ChangeDescripton, etc..
I would prefer if this was addressed on a framework level. Otherwise
we end up with a lot of duplication solving the same problems in each
framework client. I have opened a bug to discuss this further:
332589: specify concurrency model for EMF data model
https://bugs.eclipse.org/bugs/show_bug.cgi?id=332589
Steffen
--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com
