Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-reviews-dev] renaming of plug-ins

The main difference with the tbr vs. tasks namespace is that we can leave out the reviews segment:

 org.eclipse.mylyn.reviews.tasks.core  vs.
 org.eclipse.mylyn.tbr.core

While we are discussing this... the API in org.eclipse.reviews.frame.core exposes EMF types. Is that intentional? It could make sense as clients are likely to extend the model but I was wondering if that has been discussed?

What about concurrent access to the model? EMF is not inherently thread safe. Is there a bug for addressing this, e.g. through EMF Transactions?

Steffen


On Wed, Nov 24, 2010 at 6:51 AM, alvaro sanchez <alvsan09@xxxxxxxxx> wrote:
Hello,
For the proposal to use the following bundle names for the framework:

org.eclipse.mylyn.reviews.core
org.eclipse.mylyn.reviews.ui

The proposal is fine with me. 

the proposed names for Task based reviews are both fine with me, but I lean more towards "Tasks" vs "TBR", since it's more meaningful and only two letters longer :-)

/Alvaro



On Wed, Nov 24, 2010 at 9:35 AM, Steffen Pingel <steffen.pingel@xxxxxxxxxxx> wrote:
Hi,

I won't be able to join tomorrow's conference call since I'll be giving a talk at that time. I just wanted to give a quick update on the CQ for bug 326729.

The CQ was approved for parallel IP and I have committed the code to a new Git repository: /gitroot/mylyn/org.eclipse.mylyn.reviews.ui.git/ .

Please feel free to make changes but do not leak any of the IP into other repositories until the CQ is fully approved (some paper work is missing). This is just a precaution in case we need to remove sources from the history later on.

Once we have a green light I would like to merge the ui repository into the main repository.

Moving forward I would like to rename some of the bundles and introduce a proper split between API and internals following the standard Eclipse conventions.

For the framework I propose that we use these bundle names:

 org.eclipse.mylyn.reviews.core
 org.eclipse.mylyn.reviews.ui

Any thoughts on good names for the TBR bundles which are currently using this namespace? I was thinking org.eclipse.mylyn.reviews.tasks.core could work. On the other hand, org.eclipse.mylyn.tbr.core would be more consistent with the standard naming conventions and also shorter.

Steffen

--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com

_______________________________________________
mylyn-reviews-dev mailing list
mylyn-reviews-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev



_______________________________________________
mylyn-reviews-dev mailing list
mylyn-reviews-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev




--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com

Back to the top