Re: [mylyn-reviews-dev] contribution based on Atlassian Connector for Ec

[Steffen Pingel <steffen.pingel@xxxxxxxxxxx>]

To test the UI components:

1. Create a project

2. Use Team > Create Review (ignore the error dialog)

A task will be created and activated

4. Open a Java file

5. Select a few lines and use Comment on Selected Lines from the editor popup menu

6. Post a comment

A colored bar will appear in the Crucible Comments ruler and the comment should appear on hover.

Note that the actions in the tooltip are not functional and other UI contributions will probably not work either.

Steffen

On Wed, Sep 22, 2010 at 6:39 PM, Steffen Pingel <steffen.pingel@xxxxxxxxxxx> wrote:

Hi,

I have started extracting reusable UI components from Atlassian's
Crucible integration for Eclipse that we could consider for IP review
in order to merge them into the Reviews framework. You can find the
code at http://github.com/spingel/mylyn-reviews . My suggestion would
be to only submit the code contained in
com.atlassian.connector.eclipse.crucible.ui. It provides the following
functionality:

* A wizard for creating reviews
* An annotation model with hovers
* A ruler with hovers
* Actions and dialogs to add line based comments

Right now this works in the local workspace. The other plug-ins in the
repository provide the data model and utility classes but they are
mostly Crucible specific and some licensed under the ASF license so I
do not plan to include them in the IP review. We would need to replace
them with a generic model (bug 324327) and refactor the code
accordingly.

For the team integration we could consider submitting
com.atlassian.connector.eclipse.team.ui as a basis for the Mylyn SCM
project but I am not yet sure whether its worth the effort.

Let me know what you think.

Steffen

--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com

--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com