Re: [mylyn-reviews-dev] Extension point for file history

["Stefan Reiterer" <stefan.reiterer@xxxxxxxxxxxxxxxxx>]

Hi!

My name is Stefan and in the course of my master thesis I develop  
adapters for connecting Mylyn Reviews with several SCM systems.

I inspected the interface and accounted some areas where it is  
necessary to extend your specification.
- I think each method requires the project (IProject) as additional  
parameter to specify for which project the version control information  
should be received.
- At least the methods ?getFileForRevision? and ?getRevisionForDate?  
require a progress monitor (IProgressMonitor) as additional parameter,  
because they involve time consuming operations (establish connection  
to server, ?).
- Each method should throw at least one exception to inform the caller  
about a specific exception.


Enhanced interface:

public interface ISCMAdapter {

	ReaderCreator getFileForRevision(IRevision revision,
			IProject project, String path, IProgressMonitor monitor) throws  
CoreException;

    // this method is probably not be well suited for cvs.
    IRevision getRevisionForDate(java.util.Date date,
    		IProject project, IProgressMonitor monitor) throws CoreException;

    List<IChangeset> getChangesetsForTask(String taskId, String  
repositoryUrl) throws CoreException;

}

Lg.
Stefan