Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-integrators] Can TaskComment be subclassed?

To further the discussion I quote a bit from http://www.codeguru.com/java/tij/tij0127.shtml

Here is the output from three different runs:
Duplication via serialization: 3400 Milliseconds
Duplication via cloning: 110 Milliseconds

Duplication via serialization: 3410 Milliseconds
Duplication via cloning: 110 Milliseconds

Duplication via serialization: 3520 Milliseconds
Duplication via cloning: 110 Milliseconds
So I think that your bug report should somehow identify the problem properly and prefer a proper deep-cloneable implementation, if only for performance reasons. To loose the subclassing will kill the current work on the generic SQL connector:
 bug 184532: [connector] Generic SQL connector
https://bugs.eclipse.org/bugs/show_bug.cgi?id=184532
It will also probably severely hinder connector implementors.
There are just too many open bug reports with the [connector] keyword in it! I'm willing to contribute on this so lets outline the two alternatives in terms of work.
Maarten Meijer

Op 26 mrt 2008, om 00:39 heeft Robert Elves het volgende geschreven:
Shawn and I were just discussing this further and are of the mind that the class loading issue could be resolved if Mylyn participated in buddy policies. But since this is not ideal nor likely (at least for 3.0) you will have to make use the the standard TaskComment class. This raises an interesting issue wrt the api: TaskComment and all TaskData related classes should be final. I'll create a new bug report to address this.

The stack track you reported below appears to be a result of this same problem.

-Rob



Back to the top