Re: [mylyn-integrators] Why has people section been removed from Abstrac

[Robert Elves <rob.elves@xxxxxxxxxxx>]

Hi Dennis,

Good point Dennis.  We are in the process of decomposing the task 
editors (for Mylyn 3.0) and I've posted to the following but to consider 
this problem when refactoring:

179254: [api] AbstractRepositoryTaskEditor needs to be decomposed
https://bugs.eclipse.org/bugs/show_bug.cgi?id=179254

So for now you're stuck with duplicate code but you will be able to 
clean this up when migrating to  Mylyn 3.0.

-Rob


Dennis Rietmann wrote:
> Hi Rob,
>
> yes of course that's possible (and actually is what I currently do), 
> but it leads to code duplication. In my case I have to copy the code 
> from AbstractRepositoryTaskEditor.createPeopleLayout into my subclass. 
> My main question therefore is: Why did you decide to leave 
> AbstractNewRepositoryTaskEditor.createPeopleLayout empty without 
> calling the super impl.? Shouldn't it be the decision of the 
> subclasses whether they want the people layout or not?
>
> thanks,
>
> Dennis
>
> On Feb 14, 2008 6:24 PM, Robert Elves <rob.elves@xxxxxxxxxxx 
> <mailto:rob.elves@xxxxxxxxxxx>> wrote:
>
>     This method can be overridden (as it is by the
>     NewBugzillaTaskEditor) to
>     add support for assigning new bugs.
>     If your question pertains to an existing connector, feel free to
>     submit
>     a new bug report requesting this functionality be added:
>
>      https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Mylyn
>
>     -Rob
>
>     Dennis Rietmann wrote:
>     > Hi,
>     >
>     > I'm wondering why the people section has been removed from the
>     > AbstractNewRepositoryTaskEditor. createPeopleLayout() is empty with
>     > the comment "new editor doesn't have people section". For users
>     > outside of the project this makes perfect sense (they shouldn't be
>     > able to assign the bugs), but if a project developer reports a
>     bug he
>     > may know whom to assign it. But this is not directly possible
>     with the
>     > current solution. Instead he has to create the bug and then do
>     an update.
>     >
>     > cheers,
>     > Dennis
>     >
>     ------------------------------------------------------------------------
>     >
>     > _______________________________________________
>     > mylyn-integrators mailing list
>     > mylyn-integrators@xxxxxxxxxxx <mailto:mylyn-integrators@xxxxxxxxxxx>
>     > https://dev.eclipse.org/mailman/listinfo/mylyn-integrators
>     >
>
>
>     --
>     Robert Elves
>     Mylyn Committer, http://eclipse.org/mylyn
>
>     _______________________________________________
>     mylyn-integrators mailing list
>     mylyn-integrators@xxxxxxxxxxx <mailto:mylyn-integrators@xxxxxxxxxxx>
>     https://dev.eclipse.org/mailman/listinfo/mylyn-integrators
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> mylyn-integrators mailing list
> mylyn-integrators@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-integrators
>   


--
Robert Elves
Mylyn Committer, http://eclipse.org/mylyn