Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-integrators] AbstractRepository.credentialsComplete() not behaving as expected

Hi Steffen,

Well in this case I will do some copy & paste until it is fixed ;-)

I just reported it at https://bugs.eclipse.org/bugs/show_bug.cgi?id=215919 - I hope everything is ok.

Dennis

On Jan 21, 2008 12:29 AM, Steffen Pingel <steffenp@xxxxxx> wrote:
Hi Dennis,

I can't think of a good reason why username and password are only required if
anonymous access is supported. Unfortunately we won't be able to change that
for Mylyn 2.x as it would break backwards compatibility. Please go ahead and
file a bug against Mylyn so this can be adressed for 3.0:

 http://www.eclipse.org/mylyn/bugs/

As a work-around I suggest to overwrite isPageComplete() and copy the code
from AbstractRepositorySettingsPage for now.

Steffen



On Wednesday 19 December 2007, Dennis Rietmann wrote:
> Hi,
>
> I have a small question regarding the Repository settings dialog:
> AbstractRepository.credentialsComplete() validates the credentials but only
> if needsAnonymousLogin() is true - why is that so?
> This doesn't make any sense to me, I mean if I set
> setNeedsAnonymousLogin(false) meaning that no anonymous access is possible
> the credentials should be validated as well... (of course I could do this
> myself in isPageComplete() but the right place would be in
> credentialsComplete()).
>
> cheers,
> Dennis



--
Steffen Pingel - steffenp@xxxxxx - http://steffenpingel.de
_______________________________________________
mylyn-integrators mailing list
mylyn-integrators@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-integrators


Back to the top