Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-docs-dev] Migration to Github?


On Fri, Mar 25, 2022 at 11:26 PM Leo Dos Santos <leo.dos.santos@xxxxxxxxxxx> wrote:
Yes, Denis’s blog post earlier this week https://blogs.eclipse.org/post/denis-roy/moving-eclipse-projects-github-and-gitlab had me thinking about the situation again. I agree that it’s preferable to be proactive about the move, rather than force ourselves into it down the road. Normally I’d say let’s do this after the Java 11 work is finished, but since you’ve been taking that on yourself, you’re in a better position to say how that’s going. 

* Do we want to do a Java 11 based Wikitext release ahead of Github migration?

No, migration is pretty flawless so I don't see the need for such a release. Furthermore, Java 11 switch as bytecode is complete but we can make some more use of new APIs. Just delayed till Platform github migration is complete.
 
* If so, should we bump up the version to 3.1 (as this will break compatibility with Java 8/9 runtimes).

I may look into this but not right now so if someone can help that would be more than welcome.
 

Regardless of these choices, I vote positively that we take on the Github migration next.

- Leo

On Mar 25, 2022, at 1:33 PM, Aleksandar Kurtakov <akurtako@xxxxxxxxxx> wrote:

Hey everyone,
Here is the current proposal plan from EF for shutdown of Gerrit and Bugzilla https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Gerrit/Gerrit-and-Bugzilla-deprecation-and-migration-plan . Aka if we don't move, we will be force moved in a year or so. IMHO, it's better to be proactive and not wait. Github is better option as:
* many devs already have github accounts so no need to learn new tool as much as GitLab is similar, even having one less account is worth it
* dependabot and other GH bots and actions

If there is agreement, I can drive the move.

On Sat, Nov 27, 2021 at 8:54 AM Aleksandar Kurtakov <akurtako@xxxxxxxxxx> wrote:


On Sat, Nov 27, 2021 at 3:47 AM Leo Dos Santos <leo.dos.santos@xxxxxxxxxxx> wrote:
Interesting development. I can’t say I was very fond of the Github reviews feature last time I used it, but that was admittedly a few years ago and hopefully it has improved.

It's worth noting that dependabot helps us stay on top of our dependencies updates in tycho - see https://github.com/eclipse/tycho/search?q=dependabot&type=commits after the commits enabling it, it handled good number of updates.  Combined with licensecheck maven plugin (https://github.com/eclipse/dash-licenses/) IPzilla/CQ/ClearlyDefined approval is smth that can be verified at every build. 
--- license-tool-plugin:0.0.1-SNAPSHOT:license-check (default-cli) @ parent ---
[INFO] Querying Eclipse Foundation for license data for 166 items.
[INFO] Found 166 items.
[INFO] Vetted license information was found for all content. No further investigation is required.
[INFO] Summary file was written to: /home/jenkins/agent/workspace/lsp4e-github_master/target/dash/summary

From https://ci.eclipse.org/lsp4e/job/lsp4e-github/job/master/18/console .

Having these updates handled for us is smth totally impossible on gerrit infrastructure now but saves so much time.
 

Aleksandar, how much friction was there in the migration process for the other projects you were on? Migrating the git repo will obviously require updating our builds. One of our release builds does some git repo tagging (I think through mvn-release plugin) that required some assistance from the Eclipse CI/Jenkins team to initially help set up, and then again to migrate to the JIPP infrastructure. I think a ci-bot specific to the project needed to be set up with write access to the repo. Do you know if this is still supported on Github? As long as we can port our builds quickly, I don’t have issues moving to Github.

Migration was pretty straightforward e.g. for lsp4e it literally costed a day to do minor changes to jenkins. Foundation provides a bot to do tagging too as per https://wiki.eclipse.org/CBI#GitHub_and_Bot_Accounts so I assume that should be pretty straightforward but haven't used it yet.
 

I’m also curious about how Github hosted contributions tie into the ECA? Will contributors need to have both an Eclipse.org account, and a Github account that’s linked to the Eclipse account? I find that Eclipse.org registration seems to be a point of friction for some of our newer contributors at Tasktop, but I imagine that step still a requirement even when the contribution is coming from Github.

ECA is still validated and users has to sign it with same email as their github account. E.g. shows ECA verification for one specific PR https://accounts.eclipse.org/legal/eca/validation/85619
 

Thanks,
Leo

On Nov 24, 2021, at 1:56 AM, Aleksandar Kurtakov <akurtako@xxxxxxxxxx> wrote:



On Wed, Nov 24, 2021 at 11:48 AM Torkild U. Resheim <torkildr@xxxxxxxxx> wrote:
Hi all,

I assume you mean Mylyn Docs and not LSP4E, but yes. This change will affect Mylyn Docs too. I think GitHub is a good choice.

Oops. Yes, I mean Mylyn Docs. And as I mentioned LSP4E the move to github already attracted new contributor - https://github.com/eclipse/lsp4e/commits/master .
 

--
Med vennlig hilsen
Torkild Ulvøy Resheim
Senior Systemutvikler

Adresse: Brøsetvegen 164B, 7069 Trondheim
Telefon: 922 43 638
E-post: tur@xxxxxxxx
www.itema.no

> 16. nov. 2021 kl. 17:04 skrev Aleksandar Kurtakov <akurtako@xxxxxxxxxx>:
>
> Hi all,
>
> Eclipse Foundation is willing to shutdown Gerrit. https://bugs.eclipse.org/bugs/show_bug.cgi?id=577152
> It seems that now is a right time to consider migrating LSP4E to GitHub.
>
> The plan would be to migrate the Git repo, and start with an empty list of issues on GitHub; issues on Bugzilla would receive a notification that LSP4E is adopting GitHub issues and reporters should re-report their issues there if still relevant.
> That's how we did thing for m2e and Tycho in the last years, and we've seen a good impact on projects overall.
>
> What do you think?
>
> --
> Aleksandar Kurtakov
> Red Hat Eclipse Team
> _______________________________________________
> mylyn-docs-dev mailing list
> mylyn-docs-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-docs-dev

_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-docs-dev


--
Aleksandar Kurtakov
Red Hat Eclipse Team
_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-docs-dev

--
Leo Dos Santos
Senior Software Engineer, Tasktop Integrations

_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-docs-dev


--
Aleksandar Kurtakov
Red Hat Eclipse Team


--
Aleksandar Kurtakov
Red Hat Eclipse Team
_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-docs-dev

--
Leo Dos Santos
Senior Software Engineer, Tasktop Integrations

_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-docs-dev


--
Aleksandar Kurtakov
Red Hat Eclipse Team

Back to the top