Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-docs-dev] Gerrit permission

Hi David,


Gerrit retrigger is still not working for me. I have tried it right now.

Maybe it is related to the problem you got with Bug 511991.

 

Thanks to the changes you made, Gerrit is now much more stable.


Jeremie.



Le 08.02.2017 01:21, David Green a écrit :

Jeremie,

I agree, I'd like to get this problem fixed so that retriggering isn't needed.
 
I've added you to the build with the appropriate permissions.  Let me know if you have any further problems with this.

David

On Tue, Feb 7, 2017 at 10:46 AM Jeremie Bresson <dev@xxxxxxxx> wrote:

Hi David,

The situation with the final build step in the Job triggered by Gerrit is frustrating.

Could I have the permission to retrigger job? When I visit the page, I get this error "X is missing the ManualTrigger permission".
Can you also explain the steps to "wipe out the Hudson workspace" (of course I hope I can also get the corresponding permission).

Maybe I need to ask the eclipse webmaster.

Thank you in advance,

Jeremie

 

Le 06.02.2017 22:32, David Green a écrit :

Jeremie,
 
You don't have a problem with your API baseline, addressing the @since javadoc annotation errors is something that we haven't yet done.  Those errors were introduced with the refactoring but should be easily solvable by updating the source with the appropriate annotations.  Feel free to add those if you're motivated.
 
The "tika" bundles are not a WikiText dependency, so they were not added to the WikiText target platform.  They are needed for the epub bundles however, so perhaps we should add them to the WikiText target.  I was originally thinking that we should keep the WikiText target as clean as possible, only having dependencies required for WikiText - but on second thought I don't know if it's worth maintaining separate development targets for epub.
 
Apologies for any friction that I've caused in the project.  This was to be expected somewhat with such a large refactoring.  Hopefully we can get this resolved quickly.
 
On another note I've noticed that the review trigger build occasionally fails in the final stages: https://hudson.eclipse.org/mylyn/job/gerrit-mylyn-docs/1067/console
 
[INFO] [INFO] Mylyn Docs ........................................ FAILURE [0.078s]
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time: 1:05.033s
[INFO] [INFO] Finished at: Mon Feb 06 13:32:38 EST 2017
[INFO] [INFO] Final Memory: 225M/1000M
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:0.21.0:update-site (default-update-site) on project org.eclipse.mylyn.docs-site: Could not resolve plugin org.eclipse.mylyn.wikitext_3.0.0.20170206131300; Path to dependency:
[INFO] [ERROR] eclipse-feature:org.eclipse.mylyn.wikitext_feature:3.0.0.N20170206-1811: /jobs/genie.mylyn/gerrit-mylyn-docs/workspace/.local-repo/p2/org/eclipse/update/feature/org.eclipse.mylyn.wikitext_feature/3.0.0.N20170206-1811/org.eclipse.mylyn.wikitext_feature-3.0.0.N20170206-1811.jar
[INFO] [ERROR] eclipse-feature:org.eclipse.mylyn.wikitext.editors_feature:3.0.0.N20170206-1811: /jobs/genie.mylyn/gerrit-mylyn-docs/workspace/.local-repo/p2/org/eclipse/update/feature/org.eclipse.mylyn.wikitext.editors_feature/3.0.0.N20170206-1811/org.eclipse.mylyn.wikitext.editors_feature-3.0.0.N20170206-1811.jar
 
It's not clear to my why this problem occurs - and it can easily be resolved by wiping out the Hudson workspace for that build job and retriggering.  My best guess is that it's related to the local p2 cache used by tycho containing wikitext artifacts from another build.  If you have any ideas on that please let me know.
 
Regards,
 
David
 

On Mon, Feb 6, 2017 at 1:01 PM Jeremie Bresson <dev@xxxxxxxx> wrote:

I have taken my Eclipse installed with Oomph "Eclipse for Java developers" + "Mylyn Docs".
As pointed by David in his post, the Oomph setup is broken at the moment.

I have cleaned my workspace (deleted all projects) and cleaned my git repo (did an hard reset on master + deleted all ignored files).

Then I have:

1. Created two empty files:
* {org.eclipse.mylyn.docs repo}/wikitext/ui/org.eclipse.mylyn.wikitext.help.ui/help/Mylyn-WikiText-User-Guide-toc.xml
* {org.eclipse.mylyn.docs repo}/wikitext/ui/org.eclipse.mylyn.wikitext.help.ui/help/devguide/WikiText-Developer-Guide-toc.xml
[NOTE: Oomph can be called on the corresponding "create ressource" steps to do it]

2. Run "mvn verify" in {org.eclipse.mylyn.docs repo}/wikitext/core to generate the MANIFEST.MF files from the maven command line.
[NOTE: I do not see how Oomph can do this]

3. Imported the projects in Eclipse IDE. Ensure to have activated "Search for nested project".
[NOTE: the Oomph config to import projects right now is broken, I need to investigate]

4. Used "{org.eclipse.mylyn.docs repo}/wikitext/ui/targets/wikitext-development.target" as active "Target Platform".
[NOTE: Oomph uses normally the targlet concept. I am not an expert in this domain]

----
With this setup, I still have 46 errors in the error view. See the attached File.

Most of them are problems with the @since annotations.
* Do I have a problem with the API baseline (or are the Error markers correct and the code needs to be fixed)?
* Where are the 'org.apache.tika.core' and 'org.apache.tika.parsers' bundles? Why are they missing from the target platform files?

Have you also these error markers in your workspace?

----
For the Oomph Setup:

In my opinion, not having the MANIFEST.MF from the core artifacts in the Git repo is a blocker for Oomph.
My next step will be to ask for idea in the Oomph forum, but I am not sure there will be a solution for that.

 

Le 04.02.2017 01:41, David Green a écrit :

Devs,
 
I've created a new target platform which can be used for WikiText development:  /org.eclipse.mylyn.wikitext.targets/wikitext-development.target
 
After running a maven build once locally from <mylyn.docs>/wikitext you'll find that the OSGi manifests are generated for core bundles, which will make development of UI bundles easier.
 
@Jeremie if you're interested in updating the oomph setup this could be a good time to do that.
 
If you have WikiText projects open in your workspace, you'll want to re-import them from the Git repository since many of them have been renamed.  Also, Gerrit reviews will need rebasing.
 
If you notice any problems with the build or anything else, please comment on the bug:
 
 
Thanks and happy coding!

David
 
--


David Green | VP of Architecture Tasktop

email: david.green@xxxxxxxxxxx

_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev

 

_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
--


David Green | VP of Architecture Tasktop

email: david.green@xxxxxxxxxxx


_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev

 

_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
--


David Green | VP of Architecture Tasktop

email: david.green@xxxxxxxxxxx


_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev


Attachment: blocked.gif
Description: GIF image


Back to the top