Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-docs-dev] exploring changes to Mylyn Docs build

Jeremie,

Thanks for chiming in with your thoughts.  The benefits that I'm hoping to achieve are:

* easier to build/release Mylyn Docs (or at least Mylyn WikiText) separately from Mylyn
* easier to consume Mylyn WikiText core bundles (e.g. as plain jars, with normal poms)
* easier to contribute (e.g. without knowledge of OSGi or PDE)
* better structured code/tests (e.g. using normal Maven project layout)
* faster cycle time (e.g. easier to verify code changes, faster builds)

On improving the UI development workflow, it is possible to generate the necessary files.  It has been done before and is certainly something that we could look at doing.  See http://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#eclipsepde-integration for one approach.  It's unclear to me whether m2e and PDE can co-exist on the same project, and taking this on would definitely introduce some complexity to our poms.  I'm not planning on taking it on but if someone was motivated they could look into it further.

So far I haven't seen any objections to proceeding with the proposed approach, so there is nothing holding us back other than finishing the work.  

David

On Tue, Jan 31, 2017 at 1:26 AM Jeremie Bresson <dev@xxxxxxxx> wrote:

Hi,

Some inputs from my side:


If the only goal you follow is to be published on maven central, we can keep the current build/repository layout and do the approach described by Stephan Herrmann on his blog.

The CBI-Aggregator can be used to get the core bundles from the P2-Repo and republish them on a maven repository. I am doing this since a few years now. The only reason why I am only pushing to my bintray repository and not on maven central is that I do not have the permission to push on maven central. See: https://bugs.eclipse.org/bugs/show_bug.cgi?id=421551


----

I have no idea if we should switch to this new approach or not. Almost all my contributions are in the "core" part of wikitext. The current layout is not an issue for me. I have learned to work with it.

On the other side, I appreciate the effort made by David in the maven-build approach. I am ready to help where I can. I have started to bring some ideas.


Sam has produced valid points for guys who work on "wikitext-core" and on "wikitext-ui" on the same time. I am not an expert here, but to start and debug the "core" parts from Eclipse IDE in an OSGi runtime (Eclipse RCP or whatever), only the OSGi Metadata File are missing. Can they not be added to the repo, even if they are ignored by the maven build?


I my opinion we need to move fast on this topic (accept or reject the proposal). I have the feeling that my regular contributions are not reviewed at the moment, because we are waiting on this debate to be closed.




Le 26.01.2017 23:40, David Green a écrit :

All,
 
I've opened the following bug to track this effort:
 
 
You can see the results of what I've done so far, with this review being the tip of the chain: https://git.eclipse.org/r/#/c/89651/
Note that some of the changes don't build - only from the last review does the whole chain build properly.
 
Some things left to do:
 
* iterate as needed to improve the changes until we're ready to merge
* update sites - do we want WikiText in the Mylyn Docs site or separate?
* determine where and how to publish the Maven artifacts from the core part of the build
* update build jobs accordingly (Gerrit review verification, snapshot and release builds)
* determine if or how this affects EPP contributions
 
I'd appreciate your feedback on the bug or on the reviews.

Thanks,

David

On Fri, Dec 2, 2016 at 9:47 AM David Green <david.green@xxxxxxxxxxx> wrote:
Devs,
 
I've been experimenting with restructuring the Mylyn Docs build to achieve a few things:
 
* easier to build/release Mylyn Docs (or at least Mylyn WikiText) separately from Mylyn
* easier to consume Mylyn WikiText core bundles (e.g. as plain jars, with normal poms)
* easier to contribute (e.g. without knowledge of OSGi or PDE)
* better structured code/tests (e.g. using normal Maven project layout)
* faster cycle time (e.g. easier to verify code changes, faster builds)
 
To achieve these things I've been looking at building the "core" wikitext bundles as normal Maven artifacts, using a Maven plug-in to generate OSGi manifests.
 
You can see the results of my experiment here: https://github.com/greensopinion/mylyn.docs
 
The build is split into two parts: a "core" part which is Tycho-less, and a UI/OSGi part which uses Tycho.
 
I'd love to get your thoughts and feedback on the goals and the approach.
 
David
 
 
--


David Green | VP of Architecture Tasktop

email: david.green@xxxxxxxxxxx

--


David Green | VP of Architecture Tasktop

email: david.green@xxxxxxxxxxx


_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
--


David Green | VP of Architecture Tasktop

email: david.green@xxxxxxxxxxx

GIF image

GIF image


Back to the top