Re: [mylyn-docs-dev] CQ needed?

[Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx>]

Jeremie,

The header states:
Jeremie Bresson - initial API and implementation

If you copied it from some other implementation. Then the header should reflect that, eg., "copied from .... and adapted to AsciiDoc".

It's +1000 lines. Thus, a CQ is necessary.

-Gunnar

-- 
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx, http://guw.io/






> On 28 Oct 2016, at 09:17, Jeremie Bresson <dev@xxxxxxxx> wrote:
> 
> Dear Mylyn Wikitext commiters,
> 
> Gerrit has indicated that the last change I have pushed probably needs a CQ. As I wrote in Bugzilla my implementation is an adaptation of what already exist in the markdown support of Mylyn Wikitext project. I took it as base and started to modify it.
> 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=506643
> https://git.eclipse.org/r/#/c/84040/
> 
> I hope this CQ stuff will not slow the contribution too much. Please tell me what I can do to help you with the process.
> 
> You can read more about this feature on my blog:
> http://jmini.github.io/blog/2016/2016-10-28_from_mediawiki_to_asciidoc.html
> 
> Thank you in advance,
> Jeremie
> _______________________________________________
> mylyn-docs-dev mailing list
> mylyn-docs-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev