Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-docs-dev] Working on Mylyn Wikitext with Mars

Jeremie,

Great to hear that you're having success with Oomph.  Feel free to submit fixes for any issues that you see (e.g. with @see, etc.)

As far as formatting, I agree it's a pain that we've experienced on other projects as well.  I'm +1 for adopting Mars in full for developers, reformatting files incrementally as they change for other reasons rather than reformatting for the sake of it.  I'd rather not have a review go through that reformats all of the files since it can make comparing with older versions more difficult.

Thoughts?

David

On Sat, Jun 27, 2015 at 3:27 AM Jeremie Bresson <dev@xxxxxxxx> wrote:
Today I wanted to contribute something to Mylyn Wikitext.

I first took my old workspace. This was not a good idea, because I did
not manage to have a clean workspace...

Then I thought it would be a good idea to setup a new Workspace with the
brand new Eclipse Mars IDE.

There is an Oomph profile to provision the Mylyn Docs project. This is
really nice!
Thank you so much for that, it really simplify the IDE setup when
working on Mylyn Docs.

------

When you open the new workspace (provisioned with Oomph) you have some
errors:

(1) at
org.eclipse.mylyn.wikitext.core.parser.IdGenerator.hasAnchorNames()
Invalid @since 2.5 tag on hasAnchorNames(); expecting @since 2.6

(2) at
org.eclipse.mylyn.wikitext.confluence.core.ConfluenceLanguage.clone()
Missing @since tag on clone()

(3) in the org.eclipse.mylyn.wikitext.help.ui/plugin.xml file
* Referenced resource 'help/Mylyn WikiText User Guide-toc.xml' in
attribute 'file' cannot be found (Line 15)
* Referenced resource 'help/devguide/WikiText Developer Guide-toc.xml'
in attribute 'file' cannot be found (Line 16)

(3) are solved with a build. The missing files are generated by the
build. It makes sense.
For (1) and (2) my guess is that the baseline is wrong, but I am not
sure.

None of these errors prevents you to work on the code.
When I remember how I never managed to have a clean workspace to work on
Wikitext, this is a really big improvement.

------

I have identified another problem, when you work on Mylyn Wikitext with
this Mars Version.
My guess is that the code base is concerned by the new Java Formatter
(see Bug 303519 [1]).
When I modified some java classes a lot of lines were formatted.

If every committer agrees that the Mars IDE should be used to work on
Mylyn Wikitext, then the code based should be reformatted with the new
formatter.
Another option is to install the old formatter in Mars [2] but this is
experimental (and not a solution on the long time).

What do you think?
Did I miss something?

Regards,

Jérémie

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=303519
[2]
http://eclipse-n-mati.blogspot.fr/2015/06/eclipse-mars-how-to-switch-back-to.html
_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev

Back to the top