[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-docs-dev] Failing nightly build

Hi,

I guess I won't be able to commit anything before the EMO is done on their end. I've got a feeling this may take some more time. So feel free to apply the patch in order to get the nightlies going again.

Best regards,
Torkild

Den 3. apr. 2012 kl. 23:17 skrev Steffen Pingel:

> Thanks for taking care of that. That sounds reasonable to me and if we
> still get test failures once you have committed the change we can
> always revisit.
> 
> Steffen
> 
> 
> On Tue, Apr 3, 2012 at 11:10 PM, Torkild Ulvøy Resheim
> <torkildr@xxxxxxxxx> wrote:
>> Hi,
>> 
>> I've added a patch that will only download EpubCheck if it's not already present. Adding a switch appears to be much more cumbersome, as the tests uses the API that EpubCheck exposes. I think I would have to move all this code to a separate bundle in order to get such a scheme to work. I'll leave that exercise for later unless you feel it pressing. The patch is at: 375639: [epub][patch] EPUB validation tests should only download EpubCheck when required. https://bugs.eclipse.org/bugs/show_bug.cgi?id=375639. I also did a Gerrit run http://review.mylyn.org/#change,499
>> 
>> Best regards,
>> Torkild
>> 
>> Den 29. mars 2012 kl. 16:49 skrev Steffen Pingel:
>> 
>>> Hi,
>>> 
>>> thanks for taking care of that. I was joking when I said it was your
>>> fault. It is indeed a spurious problem with the download of the EPUB
>>> checking tool.
>>> 
>>> Adding a switch seems like a good idea as it would enable running the
>>> build offline as well. Additionally, we could consider caching the jar
>>> so it doesn't need to be re-downloaded for each build.
>>> 
>>> Steffen
>>> 
>>> 
>>> On Thu, Mar 29, 2012 at 1:16 PM, Torkild Ulvøy Resheim
>>> <torkildr@xxxxxxxxx> wrote:
>>>> Hi all,
>>>> 
>>>> Steffen pointed out to me that the last failed build was my fault, and indeed it is. Well, more precisely it is the task that downloads epubcheck in order to verify that the generated EPUBs are OK that times out. I think I'll add a switch that has to be enabled in order for these tests to run as we don't really have to run them every time.
>>>> 
>>>> Best regards
>>>> Torkild
>>>> _______________________________________________
>>>> mylyn-docs-dev mailing list
>>>> mylyn-docs-dev@xxxxxxxxxxx
>>>> http://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
>>> 
>>> 
>>> 
>>> --
>>> Steffen Pingel
>>> Senior Software Developer, Eclipse Mylyn
>>> Mylyn Tasks Lead
>>> http://tasktop.com
>>> _______________________________________________
>>> mylyn-docs-dev mailing list
>>> mylyn-docs-dev@xxxxxxxxxxx
>>> http://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
>> 
>> _______________________________________________
>> mylyn-docs-dev mailing list
>> mylyn-docs-dev@xxxxxxxxxxx
>> http://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
> 
> 
> 
> -- 
> Steffen Pingel
> Senior Software Developer, Eclipse Mylyn
> Mylyn Tasks Lead
> http://tasktop.com
> _______________________________________________
> mylyn-docs-dev mailing list
> mylyn-docs-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev