Re: [mylyn-docs-dev] Change in org.eclipse.mylyn.docs[master]: bug 33212

[Steffen Pingel <steffen.pingel@xxxxxxxxxxx>]

I have already pushed a review that contains the generated sources and
builds successfully: http://review.mylyn.org/#change,324.

Once we have figured out the rrequired target environment changes I
can go ahead and push that.

Steffen


On Sun, Feb 26, 2012 at 5:36 PM, David Green <david.green@xxxxxxxxxxx> wrote:
>
> Torkild,
>
> I recommend that we commit the generated source.  If that makes sense to you
> can you attach just the generated sources to the bug?
>
> David
>
> On Feb 24, 2012 11:24 PM, "Torkild Ulvøy Resheim (Code Review)"
> <gerrit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> Torkild Ulvøy Resheim has posted comments on this change.
>>
>> Change subject: bug 332122: Add ANT task for converting from wiki markup
>> to EPUB format  https://bugs.eclipse.org/bugs/show_bug.cgi?id=332122
>> ......................................................................
>>
>>
>> Patch Set 1: Fails; I would prefer that you didn't submit this
>>
>> The EMF generated code in o.e.m.docs.epub.core is missing and cause build
>> problems. I guess this code should not be a part of the actual contribution,
>> but I have not found a way of reliably regenerating the code at build time.
>>
>> --
>> To view, visit http://review.mylyn.org/323
>> To unsubscribe, visit http://review.mylyn.org/settings
>>
>> Gerrit-MessageType: comment
>> Gerrit-Change-Id: I4fcc2877e1735e90dcd28fd4e60db14b7b59c50e
>> Gerrit-PatchSet: 1
>> Gerrit-Project: org.eclipse.mylyn.docs
>> Gerrit-Branch: master
>> Gerrit-Owner: David Green <david.green@xxxxxxxxxxx>
>> Gerrit-Reviewer: Hudson
>> Gerrit-Reviewer: Torkild Ulvøy Resheim <torkildr@xxxxxxxxx>
>
>
> _______________________________________________
> mylyn-docs-dev mailing list
> mylyn-docs-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
>



-- 
Steffen Pingel
Senior Software Developer, Eclipse Mylyn
Mylyn Tasks Lead
http://tasktop.com