Hi guys,
Sorry to bother you again. I'm about to push some bug fixes to Gerrit, but it occured to me that the Mylyn Docs code I have may not be up to date as I've merged with the latest Eclipse master. Should I use the Gerrit master instead? I guess it would be more prudent.
Best regards, Torkild Den 7. des. 2011 kl. 07:58 skrev Steffen Pingel: I agree with David. Feel free to push the pending changes to Gerrit. We can then merge them on top of the IP reviewed contribution or we'll need another CQ for the remainder of the changes depending on the size.
Steffen On Tue, Dec 6, 2011 at 11:14 PM, David Green <david.green@xxxxxxxxxxx> wrote:
Torkild,
As far as I know, the review infrastructure on mylyn.org is not associated with the Eclipse foundation and therefore the IP process doesn't apply - Steffen can you confirm? If that's the case, then I recommend pushing and maintaining a review that reflects the original contribution covered by the IP process. You can then create dependent reviews for additional changes and enhancements that aren't covered by the CQ. Gerrit does a great job of maintaining dependencies between these changes, and when the CQ is approved it should be easy to manage integration of all of these changes to the Eclipse.org Git repository.
David On Tue, Dec 6, 2011 at 2:02 PM, Torkild Ulvøy Resheim <torkildr@xxxxxxxxx> wrote:
Hi guys,
I've lately been doing some changes to the EPUB support currently in IP-review. Some are due to requests from the reviewer, others are bug fixes and documentation updates (which are not being reviewed). I'm wondering how to proceed with these. I guess the easiest would be to wait until the IP-review is done and then push the changes to Gerrit for further processing. However I'd like your input on this.
Best regards,
Torkild
_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
--
David Green VP of Engineering, Tasktop Committer, Eclipse Mylyn
_______________________________________________
mylyn-docs-dev mailing list
mylyn-docs-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
-- Steffen Pingel Senior Software Developer, Eclipse Mylyn Mylyn Tasks Lead http://tasktop.com
_______________________________________________ mylyn-docs-dev mailing list mylyn-docs-dev@xxxxxxxxxxx http://dev.eclipse.org/mailman/listinfo/mylyn-docs-dev
|