Re: [mylyn-dev] Question: a test case in mylyn.context

[Sam Davis <sam.davis@xxxxxxxxxxx>]

Hi,

Thanks for pointing that out. It looks like it should indeed use new SaxContextWriter(). I tried running the test with that change and it fails because the DOM writer adds standalone="no" to the <?xml> element whereas the SAX writer doesn't. I've pushed a change to https://git.eclipse.org/r/50545

Cheers,

Sam

--
Sam Davis
Software Engineer, Tasktop Dev
Committer, Eclipse Mylyn
http://tasktop.com

On Fri, Jun 19, 2015 at 2:37 AM, yamamori <yamamori.a.aa@xxxxxxxxxxxxxx> wrote:

Hi,
I have a question about org.eclipse.mylyn.context.

I am using the context file of mylyn for research use,
and now I am thinking about adding some more information to the context file.
Let me propose the concept of the extension later.

The question is that o.e.m.context.tests having some strange test case.
The code is here: https://github.com/eclipse/mylyn.context/blob/master/org.eclipse.mylyn.context.tests/src/org/eclipse/mylyn/context/tests/ContextExternalizerTest.java#L112
I wonder that “new DomContextWriter()”, at line no.112 in ContextExternalizerTest.java,
should be “new SaxContextWriter()”.
Moreover, the test case altering DomContextWriter to SaxContextWriter fails, while the original test case passes.

Is this code right? or is it not used in the testing?


Regards,
Yamamori

—
Akihiro Yamamori
Graduate School of Information Science and Engineering
Tokyo Institute of Technology

yamamori.a.aa@xxxxxxxxxxxxxx

_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-dev