Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-dev] moving asciidoc forward

On 19 May 2015, at 19:03, David Green wrote:

Max,

Great to see more AsciiDoc improvements on the way.  Thanks for the
contributions.

I'm not sure what you mean by doable for list and code block support.

What I mean was that I kinda missed these in my initial implementation or rather I have them implemented but they got "lost" in the many rebases I had
to do for the initial contribution.

So I've redone them now - much better now that I grokked more of how the Block's works.

...and without them writing in asciidoc isn't that fun ;)

If
you make a contribution I'll do my best to provide timely code reviews. I
am pretty busy this week and may not be able to get to them all.

The only reason I'm pushing was I recall something about May 20th being last
day for external contributions ?

It's fine to use the one bug to track these initial contributions. When you feel like the initial contribution is complete enough, you may want to
close it off and open new bugs for additional features.

crap - I did not see this mail before - I've gone through and created bugzillas
for each of the changes.

The committer process takes time and should not be rushed. You can get a
feel for the committer process from these:

*
https://www.eclipse.org/projects/dev_process/#4_7_Committers_and_Contributors
*
https://wiki.eclipse.org/Development_Resources/HOWTO/Nominating_and_Electing_a_New_Committer
* https://dev.eclipse.org/mhonarc/lists/mylyn-dev/msg01868.html

Yes, I know - I'm already committer on other projects.

/max


David



On Mon, May 18, 2015 at 4:19 PM, Max Rydahl Andersen <manderse@xxxxxxxxxx>
wrote:

Hey,

I've added 3 new gerrit pushes:

https://git.eclipse.org/r/48026 - add support for links
https://git.eclipse.org/r/48032 - add support for images
https://git.eclipse.org/r/48114 - add support for comment and attributes

All small and below the magic 1000 lines.

I would like tomorrow to add in support for lists/code blocks.
Is that doable ?

For now I recorded these against the same big bugzilla:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=418563
should I open separate ones instead ? if yes, could you create an asciidoc
component ?

...and would it make sense to add me as committer for the asciidoc
component so I could push these
more directly and not be limited by the May 20th External contribution
deadline ?

Thanks,
/max
http://about.me/maxandersen
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-dev




--
David Green
VP of Architecture, Tasktop
Committer, Eclipse Mylyn
http://tasktop.com
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-dev


/max
http://about.me/maxandersen


Back to the top