[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-dev] Commit messages

Agreed, we should specify commit templates on a per project basis once we have agree on a template that is more suitable for Git which is discussed on bug 370038.

Steffen


On Fri, May 25, 2012 at 8:11 PM, Torkild Ulvøy Resheim <torkildr@xxxxxxxxx> wrote:
Hi all,

I completely agree with David. It would be better if we had a standardized format, and that there were Mylyn commit templates to support it. The templates can be set on a per project basis so there is no reason why we should not just go ahead and specify these for Mylyn projects.

Best regards,
Torkild

Den 25. mai 2012 kl. 17:40 skrev David Green:

While reviewing this contribution I've come across a commit message that differs from our usual format:

6020: bug 379783: [WikiText] Expand MediaWiki template recursively. [I84f80792]

The commit message looks like this:

Parent:     2ca48ed1 (bug 358671: Add support for fallback items https://bugs.eclipse.org/bugs/show_bug.cgi?id=358671)
Author:     Jeremie Bresson <dev@xxxxxxxx>
AuthorDate: 2012-05-25 13:33:51 +0200
Commit:     jmini <dev@xxxxxxxx>
CommitDate: 2012-05-25 13:33:51 +0200

bug 379783: [WikiText] Expand MediaWiki template recursively.


Added (v2): Loop detection and unit tests.
Added (v3): Corrections from code review.

Change-Id: I84f8079275f090c662186f9cf47311f688347b0b

Looking at the contributor reference (http://wiki.eclipse.org/Mylyn/Contributor_Reference) it seems that our guidelines on commit messages are pretty loose.  The format that I'm used to seeing (on Mylyn) is more like this:

379783: [WikiText] Expand MediaWiki template recursively

Add support for nested template references with loop detection

Change-Id: I84f8079275f090c662186f9cf47311f688347b0b

There is some related discussion on this bug:

370038: Remove task state from commit message template for Mylyn projects

My feeling is that we should be standardizing on commit message formats, and that the format should be supported/encouraged by the commit message template.  I'm interested to hear opinions from others, and would like to have clear guidelines in the contributor reference (even if those guidelines say that we have no specific format).

David

--
David Green
VP of Engineering, Tasktop
Committer, Eclipse Mylyn


_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-dev

-- 
Torkild Ulvøy Resheim
Consultant / Eclipse Committer / Senior Software Developer
Itema AS - http://itema.no


_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-dev




--
Steffen Pingel
Senior Software Developer, Eclipse Mylyn
Mylyn Tasks Lead
http://tasktop.com