[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-dev] Regarding reviews on EPUB support

Thanks David,

I've not tried Gerrit in a couple of days, been busy adding tests (and fixing a few bugs found). Hoping to get to 100% coverage of the API this weekend (there is not much left). I'll have another go when I'm done with that. It looks like a great tool that certainly has it's advantages, although actually using it can be a bit difficult unless you already know how to.

Thanks for the pointer. I'll dig into it. I've already added the generated code to Git as I could not figure out a good way of generating it on the fly. Also Mylyn Builds does the same, so I thought it was acceptable.

I've added two new bugs. They describe the only limitations I'm aware of with regards to fully supporting the EPUB 2.0.1 specification. I don't think they're anywhere near critical so this is something I can look at when done with the initial work. These are:

* Bug 358667 - [epub] Add support for multiple root files
* Bug 358671 - [epub] Add support for fallback items

Hope you don't mind me adding the [epub] tag. I figured it would make it easier to separate EPUB related issues from WikiText proper.

Best regards,
Torkild


Den 22. sep. 2011 kl. 23:40 skrev David Green:

> Torkild,
> 
> Comments below:
> 
> On Wed, Sep 21, 2011 at 2:04 PM, Torkild Ulvøy Resheim <torkildr@xxxxxxxxx> wrote:
> Thanks David,
> 
> I've done most of the changes you've requested through the Mylyn Gerrit and added more tests (except the Ant thing - more on that later). I'm having difficulty pushing changes to the Gerrit repository as it claims I've not done any changes (which I of course have). Meanwhile I'm pushing to https://github.com/turesheim/org.eclipse.mylyn.docs/tree/Mylyn_Review.
> 
> I suspect some of the trouble I'm having is due to lack of experience with Gerrit, so I've got a private instance I'm playing around with. I'll have another stab at pushing the latest changes to the Mylyn Gerrit.
> 
> 
> Great to hear that your Gerrit troubles are not blocking progress.  Have you had any luck pushing to Gerrit since?  If you can figure out the problem it will make reviewing your changes a lot easier.
>  
> When it comes to the Ant script that builds the EPUB it requires both WikiText and EMF. I don't have a good idea when it comes to setting up where those bundles should be loaded from as it depends on the build environment. One could always configure the "wikitext.standalone" property from the command line when building - or from the external tools launch configuration when doing it manually. Any input here is appreciated.
> 
> Your best bet is to follow the example of /org.eclipse.mylyn.help.ui/build-helper.xml and /org.eclipse.mylyn.help.ui/pom.xml which look like an effort to integrate WikiText generation into the Maven build process.  I'm not sure how you would do this with EMF - you may just want to commit the generated source.  This has the added advantage that changes to the generated source are tracked in Git.
> 
> David
>  
> 
> Best regards,
> Torkild
> _______________________________________________
> mylyn-dev mailing list
> mylyn-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
> 
> 
> 
> 
> -- 
> David Green
> VP of Engineering, Tasktop
> Committer, Eclipse Mylyn
> http://tasktop.com 
> +1-778-588-6896 ext. 115
> 
> ******************************************************
> * Check out Tasktop founder Mik Kersten's webinar    *
> * introducing our server-side solution, Tasktop Sync *
> *    September 28, 2011 9-10am PST / 12-1pm EST      *
> *       http://www.tasktop.com/about/webinars        *
> ******************************************************
> 
> _______________________________________________
> mylyn-dev mailing list
> mylyn-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-dev

Attachment: smime.p7s
Description: S/MIME cryptographic signature