Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [mylyn-dev] UI for "Import Query"

Hi Jevgeni,

Usually this kind of detailed discussion is best done on the bug report because that makes it easier to refer to should we need to revisit points that were brought up.  So please paste this question and response into the bug.  However, do not hesitate to send broader design questions to the mylyn-dev list (e.g. ones that span bug reports) or requests for feedback on a particular bug report. 

Regarding coupling mylyn.context.ui to eclipse.ui.ide, this cannot be done because it would couple the Context UI to the Eclipse IDE, precluding its use in IDE applications.  If there were no other solution what I would suggest for you to do is:
1) Copy FileSelectionDialog into mylyn.context.ui and avoid modifying it.  Change the class Javadoc comment to "COPIED FROM: @see{...}".  
2) File a bug against Platform to make FileSelectionDialog API that's reusable outside of eclipse.ui.ide.  

However, we only ever do this as a very last resort because of the high cost of copied code.  I did some quick digging and found org.eclipse.swt.widgets.FileDialog, and it looks like you should be able to use that instead.

Mik 

> -----Original Message-----
> From: mylyn-dev-bounces@xxxxxxxxxxx [mailto:mylyn-dev-
> bounces@xxxxxxxxxxx] On Behalf Of Jevgeni Holodkov
> Sent: Saturday, July 14, 2007 7:01 AM
> To: Mylyn developer discussions
> Subject: [mylyn-dev] UI for "Import Query"
> 
> Hi all,
> 
> Please, correct me, if I am going in a wrong direction. The UI I want
> to have to import the query (bug 189518
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=189518 ) is actually two
> dialogs, invoked by right-clicking on TaskList and selecting there
> "import Query". One dialog is a simple FileSelectionDialog. The user
> will select the file, it will be parsed and the ImportQueryDialog will
> be opened (same as EditQueryDialog). The problem is that I am not able
> to access FileSelectionDialog from org.eclipse.mylyn.context.ui. Can I
> add the dependency to the org.eclipse.ui.ide? If not, should I go with
> custom FileSelectionDialog?
> 
> Best regards,
> Jevgeni Holodkov
> _______________________________________________
> mylyn-dev mailing list
> mylyn-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-dev



Back to the top