[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mosquitto-dev] Auth plugin v3 interface seems to be incomplete

Martin,
Thank you for the answers.

Regarding (2), all old variables (include changed from a single
variable to inside of a struct) are NOT ONLY still present, BUT ALSO
valid?
I'd like to clarify plugin_v3 itself has all features of v2. If not,
the possibility of a bug is strong.

Regards,
Tatsuzo
2018å8æ7æ(ç) 16:14 Martin Assarsson <martin.assarsson@xxxxxxxxxx>:
>
> @Tatsuzo
> At the moment I still use 1.4.X but plan to use 1.5.X as soon as I see fit.
> 1. Yes, auth_plugin_v3 concerns only 1.5 and I'm not keen on mixing versions even if it's said to be backwards compatible.
> 2. Yes, all old variables are still present.
> 3. The variables posted to my function is only containing null and scanning the code makes it quite obvious.
> 4. Take a look in ./src/mosquitto_plugin.h from source code. History is available in git.
> 5. Backwards compatibility should be in place (don't know where I read it though). As said before, I'm not keen on mixing this though.
>
> @Wiebe
> Thanks!
> I'll take a look at those issues if they affect me in a bad way.
>
>
>
>
> -------------------------------------------------------------
> Martin Assarsson
> TiundavÃgen 12
> 746 34  BÃLSTA
>
> Tel: 0733-555256
>
> 2018-08-07 0:52 GMT+02:00 Tatsuzo Osawa <tatsuzo.osawa@xxxxxxxxx>:
>>
>> > I expect all answers are yes. If so, I guess we should first request
>> > the document of specification.
>> Sorry, I expect (1)(2)(3) are yes, but (4) is no.
>>
>> I'd like add one.
>> (5) Current external plugins can operate as it is? They can use
>> pugin_v2 interface without changing anything?
>>
>> Assume (2) is no and (5) is yes, I guess mosquitto itself has no
>> degradation, although pulgin_v3 has degradation from pulgin_v2.
>>
>> 2018å8æ7æ(ç) 7:15 Tatsuzo Osawa <tatsuzo.osawa@xxxxxxxxx>:
>> >
>> > HI Martin,
>> >
>> > Let me ask you something:
>> > (1) The auth_plugin_v3 is a new feature from mosquitto v1.5?
>> > (2) The parameters available at plugin_v2 are still available at
>> > plugin_v3? (includes the parameters changed from a single variable to
>> > a struct) I mean there is no degrade.
>> > (3) You insist something new parameters in v3 (includes the variables
>> > in the struct) are not available?
>> > (4) Is there any document what variables in the struct are available?
>> > Or the document about the difference between v2 and v3?
>> >
>> > I expect all answers are yes. If so, I guess we should first request
>> > the document of specification.
>> >
>> > Sorry if I made some rude questions because I have a little expertise
>> > about this area.
>> >
>> > Regards,
>> > Tatsuzo
>> >
>> > 2018å8æ7æ(ç) 0:50 Wiebe Cazemier <wiebe@xxxxxxxxxxxx>:
>> > >
>> > > ----- Original Message -----
>> > > > From: "Martin Assarsson" <martin.assarsson@xxxxxxxxxx>
>> > > > To: "General development discussions for the mosquitto project" <mosquitto-dev@xxxxxxxxxxx>
>> > > > Sent: Monday, 6 August, 2018 13:01:36
>> > > > Subject: [mosquitto-dev] Auth plugin v3 interface seems to be incomplete
>> > > >
>> > > > The new interface states that there are more parameters available to check.
>> > > > None of those seems to be populated though.
>> > > > Is there a reason for this?
>> > > > Daedaluz posted an issue a while ago and added a pull request fixing this.
>> > > > The pull request was unfortunately against master since develop branch were a
>> > > > bit to old then.
>> > > > The issue were closed and called a feature request.
>> > > > Is the v3 interface only experimental?
>> > > >
>> > > > // Martin
>> > >
>> > > (Other) problems with the 1.5 auth plugin mechanism have been mentioned before:
>> > >
>> > > https://dev.eclipse.org/mhonarc/lists/mosquitto-dev/msg01858.html
>> > >
>> > > I'm also waiting in anticipation how this will resolve. I'm especially eager to use the new E_POLL mechanism in Mosquitto 1.5, if that really is to be included. But, as of yet, these issues are blocking.
>> > > _______________________________________________
>> > > mosquitto-dev mailing list
>> > > mosquitto-dev@xxxxxxxxxxx
>> > > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> > > https://dev.eclipse.org/mailman/listinfo/mosquitto-dev
>> _______________________________________________
>> mosquitto-dev mailing list
>> mosquitto-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/mosquitto-dev
>
>
> _______________________________________________
> mosquitto-dev mailing list
> mosquitto-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/mosquitto-dev