Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mosquitto-dev] RFC: add listener_allow_anonymous

Hi,

> 
>    Hi Kurt,
> 
>    It looks like you haven’t signed the Eclipse Contributor Agreement -
>    see [1]https://github.com/eclipse/mosquitto/blob/master/CONTRIBUTING.md
>    #legal

Yep, indeed. I figured it was quite a complicated way of making sure
I understand my responsibility for adding a Signed-of-by: statement,
which I was already aware of.
Do I really need an Eclipse account?

Kind regards,
Kurt

> 
>    Benjamin
> 
>    Le 8 juin 2017 à 06:43, Kurt Van Dijck
>    <[2]dev.kurt@xxxxxxxxxxxxxxxxxxxxxx> a écrit :
> 
>    Hi Roger,
>    I fired a merge request on github, but some checks 'failed'. 
>    Is that a problem?
>    Kurt
> 
>      This idea of making allow anonymous a per listener is something that
>      is planned for the 1.5 release. I think what you've done looks fine
>      -
>      if you rebase it off the develop branch and submit a pull request
>      I'll
>      be happy to accept it.
> 
>      Although the develop branch didn't compile for me, I rebased onto
>      develop (this needed some work on my side too).
>      I have that branch on
>      [3]https://github.com/kurt-vd/mosquitto , branch 'develop'.
> 
>      I would like some extra documentation on the
>      interaction between allow_anonymous and listener_allow_anonymous as
>      well, that is somewhere there could be confusion.
> 
>      I put some extra documentation. Maybe this avoids the confusion.
>      Kind regards,
>      Kurt
> 
>    _______________________________________________
>    mosquitto-dev mailing list
>    [4]mosquitto-dev@xxxxxxxxxxx
>    To change your delivery options, retrieve your password, or unsubscribe
>    from this list, visit
>    https://dev.eclipse.org/mailman/listinfo/mosquitto-dev
> 
> References
> 
>    1. https://github.com/eclipse/mosquitto/blob/master/CONTRIBUTING.md#legal
>    2. mailto:dev.kurt@xxxxxxxxxxxxxxxxxxxxxx
>    3. https://github.com/kurt-vd/mosquitto
>    4. mailto:mosquitto-dev@xxxxxxxxxxx

> _______________________________________________
> mosquitto-dev mailing list
> mosquitto-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/mosquitto-dev



Back to the top