[modeling-pmc] [CQ 2342] QVT Abstract syntax support

[emo-ip-team@xxxxxxxxxxx]

http://dev.eclipse.org/ipzilla/show_bug.cgi?id=2342


Sharon Corbett <sharon.corbett@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|under_review                |awaiting_committer




--- Comment #12 from Sharon Corbett <sharon.corbett@xxxxxxxxxxx>  2008-07-11 11:01:17 ---
I've completed the high level review of this contribution and have the
following questions/comments:

1.  One of the About Files refers to the ModelMoref site and references
Sreedhar Reddy and his team at TCS with respect to ModelMorfExamples.  I do not
see a Non EPL CQ for ModelMoref?  Can we receive some feedback on whether this
code was removed from CVS and if the About file simply was missed.  If this
code is contained in the contribution, a NON EPL CQ will be required ASAP.

2.  The About Files contained do not appear to be our standard templates. 
Please arrange to provide new ones as a separate attachment to this CQ Please
refer to http://www.eclipse.org/legal/epl/about.php for the standard templates.

3.  Since the content realizes various specifications from OMG such as MOF 2.0,
OCL 2.0 and QVT 1.0 - we should actually have Non EPL CQs in our systems to
reflect this.  I know that we have not done so to date but for completeness we
should do so now.

4.  There are many Gif images contained in the contribution.  Did these
originate from Eclipse or were they authored by the committer, or?

5.  QVTTypeResolverImpl.java indicates the documentation was copied from the
inherited specification?  Can you confirm which OMG specification this is
referencing?

6.  There are many files in the contribution that only contain <copyright>
which no copyright information or license header.  These may be generated files
but they should be amended to include the copyright and license information. 
Please amend or provide feedback?

7.  RoseUMLImporterPlugin.java contains a comment "javadoc copied from base
class".  Is this base class EPL?

8.  QVTTextSourceViewerConfiguration.java contains a comment "this class
introduces the fix for Bug 195416 from SpellingReconcileStrategy 1.12".  Please
help us understand this comment.  Is the file from or does it contain code that
originated from SpellingReconcileStrategy 1.12?  And if so, where does this
code originate from and under which license?

9.  QVT.mdl contains a comment "C++ Reverse Engineered"???

10.  RoseUMLEcoreBuilder.java contains a comment "the derived implementation". 
Which implementation is this referencing?

11.  AbstractOCLParser.html and OCLParser.html contain author information of 
Author=Christian Vogt.  Was this a contributor?  If so, how large was the code
contribution?

Thanks,
Sharon




Auto-Generated Text:  IPTeam awaiting response from Committer.


-- 
Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the CQ.